Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't snap pcolor #2726

Merged
merged 2 commits into from Jan 29, 2014
Merged

Don't snap pcolor #2726

merged 2 commits into from Jan 29, 2014

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Jan 13, 2014

This is to restore the behavior prior to #2257.

@@ -7603,7 +7603,7 @@ def pcolor(self, *args, **kwargs):
ec.lower() == "none"):
kwargs['antialiaseds'] = False

collection = mcoll.PolyCollection(verts, **kwargs)
collection = mcoll.PolyCollection(verts, snap=False, **kwargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can do a kwargs.setdefault('snap', False) in another line so that at least the user can control it?

@pelson
Copy link
Member

pelson commented Jan 14, 2014

Pinging @dkillick who spotted the problem in the first place.

@mdboom
Copy link
Member Author

mdboom commented Jan 29, 2014

@pelson: I've addressed your comment about making snapping settable from outside the function.

pelson added a commit that referenced this pull request Jan 29, 2014
@pelson pelson merged commit 6a7a405 into matplotlib:v1.3.x Jan 29, 2014
@mdboom mdboom deleted the pcolorsnap branch August 7, 2014 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants