Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC/ENH : get/set_size_inches #2836

Merged
merged 3 commits into from Apr 8, 2014
Merged

Conversation

tacaswell
Copy link
Member

Added links between get_size_inches and set_size_inches

Added an np.array call to get_size_inches to return a copy of
the size, instead of a reference to the internal np.array.

Closes #2303

Added links between `get_size_inches` and `set_size_inches`

Added an `np.array` call to `get_size_inches` to return a copy of
the size, instead of a reference to the internal np.array.

Closes matplotlib#2303
@tacaswell tacaswell added this to the v1.4.0 milestone Feb 25, 2014
@NelleV
Copy link
Member

NelleV commented Feb 25, 2014

IMO, it would be nicer to have the See Also part as a section::

See Also


Else, this looks good to me. 👍 for merge

@tacaswell
Copy link
Member Author

@NelleV is the

See Also
------------

in addition to or instead of the .. alsosee::

@NelleV
Copy link
Member

NelleV commented Feb 25, 2014

It would be in replacement of the .. alsosee::
This is very very minor :)

@Tillsten
Copy link
Contributor

Also very minor: maybe add a sentence how to convert inch in cm, for us Europeans.

 - better numpydoc style
 - added inch <-> cm conversion factor
@Tillsten
Copy link
Contributor

Tillsten commented Apr 5, 2014

LGTM

size : ndarray
The size of the figure in inches

Also See
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also See -> See Also.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pelson I thought it was Also See from @NelleV comment....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-reading, I don't get that. Happy for either Nelle to confirm, or we just apply the consistency rule and I'll happily merge.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pelson
Copy link
Member

pelson commented Apr 7, 2014

Other than that, I'll merge with gusto. 👍

NelleV added a commit that referenced this pull request Apr 8, 2014
@NelleV NelleV merged commit 99d5012 into matplotlib:v1.3.x Apr 8, 2014
@tacaswell tacaswell deleted the set_size_doc branch April 8, 2014 12:48
@tacaswell
Copy link
Member Author

@NelleV Just to check, I added a commit flipping the word order right before you merged.

tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Apr 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants