Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable copying of C++ classes with nontrivial destructors #2997

Merged
merged 1 commit into from Apr 21, 2014

Conversation

jkseppan
Copy link
Member

@mdboom
Copy link
Member

mdboom commented Apr 20, 2014

No objection: Was this in response to a real bug, or just theoretical?

@tacaswell tacaswell added this to the v1.4.0 milestone Apr 20, 2014
@jkseppan
Copy link
Member Author

Theoretical - accidentally copying the FT2Font object could have explained #2916, but since the code still compiles after disabling the copy constructor, it wasn't that. It should help prevent introducing that kind of bug in the future.

mdboom added a commit that referenced this pull request Apr 21, 2014
Disable copying of C++ classes with nontrivial destructors
@mdboom mdboom merged commit 96d2e11 into matplotlib:master Apr 21, 2014
@jkseppan jkseppan deleted the rule-of-three branch April 21, 2014 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants