Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode fixes #3036

Merged
merged 1 commit into from May 3, 2014
Merged

Unicode fixes #3036

merged 1 commit into from May 3, 2014

Conversation

tacaswell
Copy link
Member

@jkseppan Can you confirm that I did not mess up your name?

The only place left we have u'...' is in test_rcparams.py which has py3k logic guards and in a comment in test_mathtext.py

 - no longer needed due to import string literal
 - close matplotlib#3028
@tacaswell
Copy link
Member Author

(missing github foo closes #3028 )

@jkseppan
Copy link
Member

jkseppan commented May 3, 2014

My name's fine, thanks for checking!

@tacaswell tacaswell added this to the v1.4.0 milestone May 3, 2014
@efiring
Copy link
Member

efiring commented May 3, 2014

I think the style changes represent a policy change. I believe we decided some time ago to keep utf-8 out of the source code; this would be consistent with http://legacy.python.org/dev/peps/pep-0008/#source-file-encoding combined with the single code base strategy for handling python 2 and 3.

@tacaswell
Copy link
Member Author

Didn't know that. I will drop the later two commits next time I am at a real computer.

@tacaswell
Copy link
Member Author

force-pushed to get rid of the utf-8 introducing commits.

efiring added a commit that referenced this pull request May 3, 2014
@efiring efiring merged commit 235a761 into matplotlib:master May 3, 2014
@tacaswell tacaswell deleted the unicode_fix branch May 4, 2014 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants