Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug #3029. #3067

Merged
merged 1 commit into from May 29, 2014
Merged

Fix for bug #3029. #3067

merged 1 commit into from May 29, 2014

Conversation

razius
Copy link
Contributor

@razius razius commented May 16, 2014

The FreeType class does not override the get_extension method, by default this method will return None.

return None

When calling the _check_for_pkg_config method a new extension will be created that what won't contain the original flags added by the add_flags method.

ext = self.get_extension()

The FreeType class does not override the ``get_extension`` method, by default this method will return None.

https://github.com/matplotlib/matplotlib/blob/6cf6063c7a3037d52545b2b7268623d33da0ecdd/setupext.py#L387

When calling the ``_check_for_pkg_config`` method a new extension will be created that what won't contain the original flags added by the ``add_flags`` method.

https://github.com/matplotlib/matplotlib/blob/6cf6063c7a3037d52545b2b7268623d33da0ecdd/setupext.py#L438
@tacaswell tacaswell added this to the v1.4.0 milestone May 16, 2014
@tacaswell
Copy link
Member

@mdboom Do we have a setup.py expert?

@mdboom
Copy link
Member

mdboom commented Oct 7, 2014

I'm sorry I missed this the first time around. I don't see how this resolves the original issue, and it ends up creating a new extension at the toplevel of the Python namespace that is not a Python extension:

>>> import freetype2
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: dynamic module does not define init function (initfreetype2)

@tacaswell: I'm going to make a new blocker issue for this.

frol referenced this pull request Jul 19, 2015
seems to be broken.  Use that only for version determination.  Warn if
pkg-config is not present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants