Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitelist mpl_toolkits tests #3154

Merged
merged 2 commits into from Jul 12, 2014

Conversation

WeatherGod
Copy link
Member

Turns out that the tests for mpl_toolkits needed to be explicitly added, as well as a need to explicitly install the baseline images as well.

Note that Travis will fail until the trisurf3d fix is applied to master.

@tacaswell
Copy link
Member

@mdboom @efiring Is there a reason these tests are not currently included?

@efiring
Copy link
Member

efiring commented Jun 28, 2014

@tacaswell, I don't recall any discussion of this; but I was not directly involved in any of the test system development. My concern would be that if Travis fails every time a change in the mpl core breaks something in 3D, for example, our already slow maintenance and development could grind to a halt. One hopes this would not occur in practice, of course.

@WeatherGod WeatherGod mentioned this pull request Jul 11, 2014
@mdboom
Copy link
Member

mdboom commented Jul 11, 2014

I don't remember why they weren't included. Oversight is the best I can think of. I agree with @efiring in general, but I think if we're saying we reasonably guarantee mpl3d works (which we do, given its limitations), we probably should be testing it. Speeding up the tests -- well -- that's a whole other ball of wax and maybe doesn't need to hold this up.

@WeatherGod
Copy link
Member Author

I force pushed a rebased version of this branch to include all of the latest fixes. I expect it to fail for the two py3k runs. I'll have a PR momentarially for that.

@WeatherGod
Copy link
Member Author

Just did another rebase and force push. Travis is running again.

@WeatherGod
Copy link
Member Author

Test pass! Anybody want to merge?

tacaswell added a commit that referenced this pull request Jul 12, 2014
@tacaswell tacaswell merged commit 5293b22 into matplotlib:master Jul 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants