Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug restore boxplot defaults #3165

Merged
merged 7 commits into from Jul 11, 2014

Conversation

tacaswell
Copy link
Member

re-base + bug fixes

supersedes #3066 closes #3042

phobson and others added 4 commits June 27, 2014 23:40
doplot for horizontal boxes (internal bxp helper function) assumes that
it will be passed an even number of positional arguments which it swaps
pair-wise.  The code to draw the fliers also passes in a format string
which breaks the assumption.

 - re-worked how `bxp` deals with the `sym` input
 - minor pep8
@tacaswell tacaswell added this to the v1.4.0 milestone Jun 28, 2014
@tacaswell tacaswell modified the milestone: v1.4.0 Jun 28, 2014
@tacaswell
Copy link
Member Author

@phobson Can you take a look at this and make sure I didn't muck the defaults up (again).

@phobson
Copy link
Member

phobson commented Jun 28, 2014

Yeah. Btw, the extra props were because the box and whiskers each had different linestyles in the original defaults. --
Paul Hobson
Sorry if this is unintelligible. I'm on my phone.

On Sat, Jun 28, 2014 at 11:31 AM, Thomas A Caswell
notifications@github.com wrote:

@phobson Can you take a look at this and make sure I didn't muck the defaults up (again).

Reply to this email directly or view it on GitHub:
#3165 (comment)

If the user passes is the string 'ro' assume they want filled circles.
This is also the old behavior.
If provided, will set the plotting style of the whiskers

capprops : dict or None (default)
If provided, will set the plotting style of the whiskers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean "caps" here, not "whiskers".

@tacaswell
Copy link
Member Author

And don't merge this yet, there is still an issue with where the management of the x-ticks

 changed labeling in cbook.box_plotstats to start at 1 to
 maintain back compatibility
@tacaswell
Copy link
Member Author

I think this should be good-to-go now.

mdboom added a commit that referenced this pull request Jul 11, 2014
@mdboom mdboom merged commit a1cfa29 into matplotlib:master Jul 11, 2014
@tacaswell tacaswell deleted the bug-restore-boxplot-defaults branch July 11, 2014 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

boxplot does not take parameters into account
5 participants