Mplot3d/depthshade #3211
Merged
Mplot3d/depthshade #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably haven't solved them all, but this gets most of them.
|
Minor comment. Looks good to me overall. |
|
Ah, missed that. Any idea why this would cause a build failure in tripcolor()? |
|
where do you see such a failure? I only see the usual Travis failure in 3.2. |
|
Errr, ok, mplot3d is still not tested because #3154 hasn't been merged yet. The test failure is with tripcolor. On a related note, there is a py3k bug in mplot3d that I just discovered and will set up a PR for. |
|
So the failure is unrelated. Shall I add a whats_new entry? |
|
nm, I didn't refresh the page to see if this was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1692