Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence some more warnings #3235

Merged
merged 7 commits into from Jul 21, 2014
Merged

Conversation

jenshnielsen
Copy link
Member

This is not ready for merge yet. But I would like to get a travis test running

@mdboom
Copy link
Member

mdboom commented Jul 12, 2014

👍, assuming Travis passes.

@tacaswell tacaswell added this to the v1.5.x milestone Jul 12, 2014
@NelleV
Copy link
Member

NelleV commented Jul 12, 2014

@jenshnielsen do you mind if we merge this? This looks good to me, and @mdboom already gave a 👍

@jenshnielsen
Copy link
Member Author

I am slightly nervous of doing this just before release without more careful testing on different platforms. But I will leave that up to you. I don't know what @tacaswell thinks?

@jenshnielsen
Copy link
Member Author

I have changed this a bit to more closely match the original. This should reduce the risk of issues on other platforms. I think this should be ready to go now if travis passes (only on master)

@jenshnielsen
Copy link
Member Author

Rebased

mdboom added a commit that referenced this pull request Jul 21, 2014
@mdboom mdboom merged commit 053648a into matplotlib:master Jul 21, 2014
@tacaswell
Copy link
Member

Do we want to cherry-pick this to the 1.4.x branch? I don't think we want to do it for 1.4.0, but it might be good to do eventually.

@mdboom
Copy link
Member

mdboom commented Jul 21, 2014

Sure. I'll go ahead and cherry-pick this.

mdboom added a commit that referenced this pull request Jul 21, 2014
@jenshnielsen
Copy link
Member Author

As discussed at SciPY I agree with @tacaswell that these warning fixes don't need to go into 1.4.0 btw would you prefer to have all these on the same branch. I am happy to combine #3241, #3244, #3282 etc. into one pull request.

@jenshnielsen jenshnielsen deleted the more_warnings branch July 22, 2014 10:57
jbmohler pushed a commit to jbmohler/matplotlib that referenced this pull request Aug 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants