New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor and bugfixes for plot_directive #3257
refactor and bugfixes for plot_directive #3257
Conversation
pep8 for plot directive.
Matplotlib now depends on Python 2.6, which has relpath
Well, behaviour -> behavior is against my origins, but hey, we're all American now.
plot_directive displaying empty parens when no figures and no source required. Was also prepending a comma to list of images when there was source links not required.
Cool. I think @dmcdougall will probably also want to review this, since he's been digging into this file pretty deeply in the past couple of days. |
@@ -111,7 +111,7 @@ | |||
|
|||
plot_apply_rcparams | |||
By default, rcParams are applied when `context` option is not used in | |||
a plot directive. This configuration option overrides this behaviour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdboom git blame
informs me that you wrote this line, but it's too early for me to think of anything facetious to say regarding the use of superfluous 'u's.
Looks good to me. |
@matthew-brett Was there anywhere specific in the docs that didn't link to source? I'd like to do a local build to sanity check it works, and then I'll merge it. |
I'm sorry, I'm ashamed to say I didn't test this other than on a doc I plot_include_source = True in the conf.py. I think you'll see the problem if you write a tiny On 7/15/14, Damon McDougall notifications@github.com wrote:
|
This doesn't break the links fixed in #3253; merging. |
MRG: refactor and bugfixes for plot_directive
@tacaswell Trying to cherry-pick the merge commit into
I'm happy to cherry-pick each commit, unless there's a procedure you'd like me take to address this. |
Look at the parent list on the merge commit. Counting from 1 get the I'd of the main line (which is normally 1) and pass that to -m. I think what is going on is that git could walk down either side of the loop to generate the diff, -m tells it which side is most like the other branch you want to pick too. |
MRG: refactor and bugfixes for plot_directive
Cherry-picked in 88fc024 |
@tacaswell Thanks! |
…irective MRG: refactor and bugfixes for plot_directive
Fix ugly output when not linking to source
Remove copy of relpath as no-longer needed
Fix some typos
Remove unused imports
Some PEP8 whitespace