New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build dep updates #3479
Build dep updates #3479
Conversation
minimum version for freetype is 2.3 closes matplotlib#3412
try: | ||
import pytz | ||
except ImportError: | ||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be raise CheckFailed("...")
otherwise you are going to get a positive (yes) return
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine because it will get added to the setup requirements list and pip-installed if it is not found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. You may want to add pip may attempt to install it afterwards text in the return message like what is done in Dateutil
Isn't pytz a dep of dateutil, and thus already covered? |
There seems to be a
|
dateutil and dateutils are two completely different packages (as I recently On Mon, Sep 8, 2014 at 1:40 PM, Thomas A Caswell notifications@github.com
|
This closes both #3423 and #3412.