New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: fix pep8 error classes E111 and E113 #3515
Conversation
Any idea why the diffs for |
I assume that the diff algorithm is not intelligent enough. The diff in meld looks a lot better |
|
||
|
||
def path_exists(ob, name, val): | ||
os.path.exists(val) | ||
os.path.exists(val) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this example ever work? This function would always return None. The Traits stuff is ancient...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for catching this. This function is unused. I'll remove it
Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
8dec09f
to
cb81f1a
Compare
any further comments ? |
edgecolor=None, | ||
facecolor=None, | ||
linewidth=None, | ||
antialiased = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are extra spaces here
How about this? Can we make this PR about any whitespace errors rather than just alignment errors? I stopped pointing them out because my eyes were bleeding. |
There are so many whitespace errors in the whole examples that fixing them all in a single PR would be to tedious to review. |
Fair enough. On that basis, then, I guess this is good to merge. |
examples: fix pep8 error classes E111 and E113
E111: indentation is not a multiple of four
E113: unexpected indentation
Steps to reproduce:
autopep8 -i --select E111,E113 */*.py