Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: fix pep8 error classes E111 and E113 #3515

Merged
merged 3 commits into from Oct 10, 2014

Conversation

thisch
Copy link
Contributor

@thisch thisch commented Sep 14, 2014

E111: indentation is not a multiple of four
E113: unexpected indentation

Steps to reproduce:
autopep8 -i --select E111,E113 */*.py

@tacaswell
Copy link
Member

Any idea why the diffs for examples/user_interfaces/interactive2.py look so bad?

@thisch
Copy link
Contributor Author

thisch commented Sep 14, 2014

I assume that the diff algorithm is not intelligent enough. The diff in meld looks a lot better

@tacaswell tacaswell added this to the v1.5.x milestone Sep 14, 2014


def path_exists(ob, name, val):
os.path.exists(val)
os.path.exists(val)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this example ever work? This function would always return None. The Traits stuff is ancient...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for catching this. This function is unused. I'll remove it

Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
Signed-off-by: Thomas Hisch <t.hisch@gmail.com>
@thisch
Copy link
Contributor Author

thisch commented Oct 6, 2014

any further comments ?

edgecolor=None,
facecolor=None,
linewidth=None,
antialiased = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are extra spaces here

@WeatherGod
Copy link
Member

How about this? Can we make this PR about any whitespace errors rather than just alignment errors? I stopped pointing them out because my eyes were bleeding.

@thisch
Copy link
Contributor Author

thisch commented Oct 10, 2014

There are so many whitespace errors in the whole examples that fixing them all in a single PR would be to tedious to review.

@WeatherGod
Copy link
Member

Fair enough. On that basis, then, I guess this is good to merge.

WeatherGod added a commit that referenced this pull request Oct 10, 2014
examples: fix pep8 error classes E111 and E113
@WeatherGod WeatherGod merged commit 5805fc3 into matplotlib:master Oct 10, 2014
@thisch thisch deleted the examples_pep8_e111_e113 branch October 10, 2014 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants