BUG : deal with empty list passed to boxplot #3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
added
status: needs revision
status: needs review
Release critical
If a data list is empty, return a dict full of np.nan. Closes matplotlib#3569 and addresses part of pandas-dev/pandas#8382
tacaswell
force-pushed
the
bxp_empty
branch
from
d043784
to
7602e3d
Compare
2 tasks
mdboom
added a commit
that referenced
this pull request
Sep 27, 2014
BUG : deal with empty list passed to boxplot
jairideout
added a commit
to jairideout/scikit-bio
that referenced
this pull request
Oct 6, 2014
Empty distributions are plottable in mpl < 1.4.0. In 1.4.0, a ValueError is raised. This has been fixed in mpl 1.4.0-dev (see matplotlib/matplotlib#3571). In order for skbio.draw.boxplots to support empty distributions across mpl versions, empty distributions are replaced with [np.nan]. See pandas-dev/pandas#8382 and pandas-dev/pandas#8240 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a data list is empty, return a dict full of np.nan.
Closes #3569 and addresses part of pandas-dev/pandas#8382
4th time's the charm on this commit.
Needs testing.