Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matplotlib.__version__ is now unicode as of 1.4.0 #3621

Merged
merged 1 commit into from Oct 7, 2014

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Oct 7, 2014

see here: pandas-dev/pandas#8502

this breaks LooseVersion (not sure why that is)

is this typical to make this unicode? (and not a plain string even in py2)?

@efiring efiring added this to the v1.4.1 milestone Oct 7, 2014
@efiring
Copy link
Member

efiring commented Oct 7, 2014

This is a consequence of using from __future__ import unicode_literals, which is a debatable design choice when writing py2/py3 code. In this instance, if it breaks LooseVersion, it is a bug--either in mpl or in LooseVersion.

@jreback
Copy link
Author

jreback commented Oct 7, 2014

ahh I see, we explicity used u() (from six) for this purpose.

ok, just wanted you guys to be aware, we can work-around.

prob IS a bug in LooseVersion though

@mdboom mdboom self-assigned this Oct 7, 2014
@mdboom
Copy link
Member

mdboom commented Oct 7, 2014

Fix attached.

@efiring
Copy link
Member

efiring commented Oct 7, 2014

@mdboom, a Github question: how do you attach a changset to an issue like this, turning it into a PR?

efiring added a commit that referenced this pull request Oct 7, 2014
matplotlib.__version__: revert from unicode to native str
@efiring efiring merged commit 68b34b0 into matplotlib:v1.4.x Oct 7, 2014
@tacaswell
Copy link
Member

It is part of the github API which you can talk to via hub or their gui client. It is going to get killed off (eventually)
mislav/hub@4f70dd1

@mdboom mdboom deleted the issue3621 branch March 3, 2015 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants