Fix compiler warning #3781
Merged
Fix compiler warning #3781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,8 +136,11 @@ class PathIterator | |||
|
|
|||
| inline unsigned vertex(double *x, double *y) | |||
| { | |||
| if (m_iterator >= m_total_vertices) | |||
| if (m_iterator >= m_total_vertices) { | |||
| *x = 0.0; | |||
There was a problem hiding this comment.
Setting the last vertex to 0 was the source of those 3D polygon bugs, is something similar going to come up here?
There was a problem hiding this comment.
I don't think so. When the code returned is agg::path_cmd_stop, the x and y values are actually meaningless and should be ignored by the caller. This fix is only to silence a compiler warning that it is theoretically possible to get a vertex where the x y values were never set (if it were a 0-length path), since the compiler doesn't understand the semantics of the vertex codes.
|
I don't think this is worth back-porting to 1.4.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a compiler warning about uninitialized values that looks like it's coming from Agg, but which is actually matplotlib's fault ;)