Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG/API : relax validation in hist #3883

Merged
merged 2 commits into from Dec 29, 2014

Conversation

tacaswell
Copy link
Member

Relax the validation on input data to hist.

  • up-convert scalar to length 1 list
  • don't error out for length 1 input data

closes #3882

Relax the validation on input data to hist.

 - up-convert scalar to length 1 list
 - don't error out for length 1 input data

closes matplotlib#3882
@tacaswell tacaswell added this to the v1.5.x milestone Dec 4, 2014
@jenshnielsen
Copy link
Member

LGTM is there any point in adding a test?

@tacaswell
Copy link
Member Author

Yes, good catch on me being lazy.

jenshnielsen added a commit that referenced this pull request Dec 29, 2014
@jenshnielsen jenshnielsen merged commit db45436 into matplotlib:master Dec 29, 2014
@tacaswell tacaswell deleted the hist_validation_relax branch December 31, 2014 23:28
@tacaswell
Copy link
Member Author

@pelson @mdboom @efiring second guessing my original view that should not be on 1.4.x. Thought?

@efiring
Copy link
Member

efiring commented Feb 4, 2015

I don't see any harm in including it in 1.4.x. But how long is this branch going to stay alive? Is there a compelling reason not to move on to 1.5.0?

@tacaswell
Copy link
Member Author

Well, in this case I am thinking about pulling it back for 1.4.3.

Do we want to shut down 1.4.x and target 1.5.0 for scipy (modulo 2.0 due to colormap changes)?

@efiring
Copy link
Member

efiring commented Feb 4, 2015

If things going into 1.5.0 are not too revolutionary, then I don't see much point in having a long series of 1.4 bugfix releases, so I think shutting 1.4.x makes sense.
Pulling the hist change into 1.4.3 is fine with me, regardless. It involves significant effort compared with accepting the rc1 as the release, though, doesn't it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hist / hist2d inconsistent for plotting single data point
3 participants