New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PEP8 coding style violations #3924
Conversation
`pep8 *.py --ignore=E501` gives no output anymore. TODO: Fix long lines As part of http://24pullrequests.com
`pep8 unit/*.py --ignore=E501` tells us everything is ok. As part of http://24pullrequests.com
@@ -1,4 +1,5 @@ | |||
import sys, datetime | |||
import sys | |||
import datetime | |||
|
|||
if len(sys.argv) != 3: | |||
print >>sys.stderr, 'Usage: license.py version_num filename' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, looks like license.py isn't py3k compatible...
I have completely forgotten about the stuff in "unit". I don't even know if they work anymore, and I don't think the tests in there even get invoked in any way. As far as this PR is concerned, I am fine with it, but we definitely need to figure out what to do with the stuff in "unit". |
tools/gh_api.py and tools/github_stats.py are copied from IPython and really shouldn't be modified more than we have to within matplotlib |
👍 on not modifying files that are not ours. |
I am not talking about lib/matplotlib/units.py. I am talking about unit/ On Tue, Dec 16, 2014 at 9:53 AM, Thomas A Caswell notifications@github.com
|
Ah, those. Never mind. Although, my statement abount documentation on units.py I think still stands. |
@jenshnielsen I wasn't aware that tools/*.py is copied from IPython (should have read the docstring). |
Yeah, that guy and I got into a huge (somewhat druken) argument about PEP8 PRs back at SciPy2014... nobody won that argument... |
@habi no problem. Perhaps we should make that more obvious somehow. |
@tacaswell I reverted the commit that touched the |
7e0fdb5 also looks kind of funny.... For neatness I would prefer to just get rid of those commits from the history. |
I think I did, by |
PEP8 : Fix PEP8 coding style violations in unit and helper scripts
Thanks. |
pep8 *.py --ignore=E501
gives no output anymore.TODO: Fix long lines
As part of http://24pullrequests.com