Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP8: adjust some long lines #3949

Merged
merged 2 commits into from Feb 19, 2015
Merged

Conversation

argriffing
Copy link

The # noqa is supposed to pacify some pep8 checkers. I left the long urls in docstrings alone.

@@ -885,7 +885,8 @@ def __getitem__(self, key):
key = alt
return dict.__getitem__(self, key)

# http://stackoverflow.com/questions/2390827/how-to-properly-subclass-dict-and-override-get-set
# http://stackoverflow.com/questions/2390827
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, very clever SO, very clever....

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for a trailing slash?

@tacaswell
Copy link
Member

New(er) versions of pep8 should ignore url lines without the need for #noqa

@tacaswell
Copy link
Member

See discussion at PyCQA/pycodestyle#326 which loops back to #3507 (comment)

@tacaswell tacaswell added this to the unassigned milestone Dec 29, 2014
@@ -28,7 +28,7 @@
# python trick. The answer is that I need to be able to manipulate
# the docstring, and there is no clever way to do that in python 2.2,
# as far as I can see - see
# http://groups.google.com/groups?hl=en&lr=&threadm=mailman.5090.1098044946.5135.python-list%40python.org&rnum=1&prev=/groups%3Fq%3D__doc__%2Bauthor%253Ajdhunter%2540ace.bsd.uchicago.edu%26hl%3Den%26btnG%3DGoogle%2BSearch
# http://groups.google.com/groups?hl=en&lr=&threadm=mailman.5090.1098044946.5135.python-list%40python.org&rnum=1&prev=/groups%3Fq%3D__doc__%2Bauthor%253Ajdhunter%2540ace.bsd.uchicago.edu%26hl%3Den%26btnG%3DGoogle%2BSearch # noqa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there was a discussion yesterday about this very link, and it is rotted as-is. There is a more correct URL to use here: https://mail.python.org/pipermail/python-list/2004-October/255696.html

@tacaswell
Copy link
Member

Can you remove the noqa markers?

@argriffing
Copy link
Author

@tacaswell OK, removed them.

tacaswell added a commit that referenced this pull request Feb 19, 2015
@tacaswell tacaswell merged commit 1fe5b9c into matplotlib:master Feb 19, 2015
@tacaswell
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants