Suppress some warnings in examples #3958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It it expected that the array may contain nan and this is handled correctly using nanmin
Avoids numpy warnings with the same result. Similar to what is done above
| if self.lat_cycle is not None: | ||
| lat0 = np.nanmin(lat) | ||
| lat -= 360. * ((lat - lat0) > 180.) | ||
| with np.errstate(invalid='ignore'): |
There was a problem hiding this comment.
note to self, should probably use np.unroll() here, I think.
There was a problem hiding this comment.
also, what exactly are we ignoring here? The other changes came with very nice explanations.
There was a problem hiding this comment.
Right you are. I guess I was being lazy 😃
I assume that np.unroll() should we np.unwrap?
There was a problem hiding this comment.
ah, right, np.unwrap(). Squishy brain matter makes for a terrible memory medium...
WeatherGod
added a commit
that referenced
this pull request
Jan 1, 2015
Supress some warnings in examples
|
very nice explanations! |
jenshnielsen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This filters a number of warnings from the examples.
I have done this for 2 reasons