New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: trigger travis OSX tests if Linux tests pass #4138
Conversation
Use travis_after_all to wait for all Linux tests to pass, before triggering the OSX tests at MacPython/matplotlib-wheels. Uses: * https://github.com/dmakhno/travis_after_all * https://github.com/ajdm/travis-build-children following model at: python-pillow/Pillow#1067 Authorization token to allow trigger of OSX build comes from: travis login travis token # My (Matthew Brett's) github token travis encrypt AUTH_TOKEN=<my_travis_token> The output becomes: env: global: - secure: "dfjNqGKzQG5bu3FnDNwLG8H/C4QoieFo4PfFmZPdM2RY7WIzukwKFNT6kiDfOrpwt+2bR7FhzjOGlDECGtlGOtYPN8XuXGjhcP4a4IfakdbDfF+D3NPIpf5VlE6776k0VpvcZBTMYJKNFIMc7QPkOwjvNJ2aXyfe3hBuGlKJzQU=" in .travis.yml
Apart from the changes here, I needed to make a new branch 'latest' in https://github.com/MacPython/matplotlib-wheels that builds and tests the latest commit on matplotlib, rather than (by default) building the latest tag: |
@matthew-brett I am being dense, how do we tell if it is working? |
Not being dense at all - the pull request that I sent, you cannot see if it is working, because it is plumbed only to trigger for the matplotlib/master branch. I did test it in a previous version where the relevant branch was matthew-brett/osx-building and it did trigger this build : https://travis-ci.org/MacPython/matplotlib-wheels/builds/51590008 - but there's no way to see that directly. I think the best thing to do would be to review for general acceptability, merge and then confirm builds are happening / fix anything not working. |
TST : trigger travis OSX tests if Linux tests pass
Fair enough, merged. It is only the travis related testing code so I am not super worried about it taking some thrashing on master to get sorted out. |
Thanks for the merge. Looking at the travis-ci page : https://travis-ci.org/matplotlib/matplotlib/builds - the merge triggered no build. Do merges to trunk trigger travis-ci builds? Now I think about it, I think travis-ci tests the merge commit of the PR into trunk, so, if you press the green merge button, unless trunk has changed since the PR was tested, travis-ci will not test the merge commit again (because it has tested it already). I wonder how to test only commits that get merged into trunk (and, I suppose, rerun tests that that have already been run on the PR)? |
Part of the problem is that our builds had been turned off on Travis (not On Mon, Feb 23, 2015, 15:18 Matthew Brett notifications@github.com wrote:
|
Use travis_after_all to wait for all Linux tests to pass, before triggering
the OSX tests at MacPython/matplotlib-wheels.
Uses:
following model at:
python-pillow/Pillow#1067
Authorization token to allow trigger of OSX build comes from:
travis token # My (Matthew Brett's) github token
travis encrypt AUTH_TOKEN=<my_travis_token>
The output becomes:
"dfjNqGKzQG5bu3FnDNwLG8H/C4QoieFo4PfFmZPdM2RY7WIzukwKFNT6kiDfOrpwt+2bR7FhzjOGlDECGtlGOtYPN8XuXGjhcP4a4IfakdbDfF+D3NPIpf5VlE6776k0VpvcZBTMYJKNFIMc7QPkOwjvNJ2aXyfe3hBuGlKJzQU="
in .travis.yml