Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: trigger travis OSX tests if Linux tests pass #4138

Merged
merged 1 commit into from Feb 23, 2015

Conversation

matthew-brett
Copy link
Contributor

Use travis_after_all to wait for all Linux tests to pass, before triggering
the OSX tests at MacPython/matplotlib-wheels.

Uses:

following model at:

python-pillow/Pillow#1067

Authorization token to allow trigger of OSX build comes from:

travis login

travis token # My (Matthew Brett's) github token
travis encrypt AUTH_TOKEN=<my_travis_token>

The output becomes:

env:
   global:
       - secure:

"dfjNqGKzQG5bu3FnDNwLG8H/C4QoieFo4PfFmZPdM2RY7WIzukwKFNT6kiDfOrpwt+2bR7FhzjOGlDECGtlGOtYPN8XuXGjhcP4a4IfakdbDfF+D3NPIpf5VlE6776k0VpvcZBTMYJKNFIMc7QPkOwjvNJ2aXyfe3hBuGlKJzQU="

in .travis.yml

Use travis_after_all to wait for all Linux tests to pass, before
triggering the OSX tests at MacPython/matplotlib-wheels.

Uses:

* https://github.com/dmakhno/travis_after_all
* https://github.com/ajdm/travis-build-children

following model at:

python-pillow/Pillow#1067

Authorization token to allow trigger of OSX build comes from:

    travis login
    travis token  # My (Matthew Brett's) github token
    travis encrypt AUTH_TOKEN=<my_travis_token>

The output becomes:

    env:
        global:
            - secure: "dfjNqGKzQG5bu3FnDNwLG8H/C4QoieFo4PfFmZPdM2RY7WIzukwKFNT6kiDfOrpwt+2bR7FhzjOGlDECGtlGOtYPN8XuXGjhcP4a4IfakdbDfF+D3NPIpf5VlE6776k0VpvcZBTMYJKNFIMc7QPkOwjvNJ2aXyfe3hBuGlKJzQU="

in .travis.yml
@matthew-brett
Copy link
Contributor Author

Apart from the changes here, I needed to make a new branch 'latest' in https://github.com/MacPython/matplotlib-wheels that builds and tests the latest commit on matplotlib, rather than (by default) building the latest tag:

MacPython/matplotlib-wheels@c8f627c

@tacaswell tacaswell added this to the next point release milestone Feb 21, 2015
@tacaswell
Copy link
Member

@matthew-brett I am being dense, how do we tell if it is working?

@matthew-brett
Copy link
Contributor Author

Not being dense at all - the pull request that I sent, you cannot see if it is working, because it is plumbed only to trigger for the matplotlib/master branch. I did test it in a previous version where the relevant branch was matthew-brett/osx-building and it did trigger this build : https://travis-ci.org/MacPython/matplotlib-wheels/builds/51590008 - but there's no way to see that directly. I think the best thing to do would be to review for general acceptability, merge and then confirm builds are happening / fix anything not working.

tacaswell added a commit that referenced this pull request Feb 23, 2015
TST : trigger travis OSX tests if Linux tests pass
@tacaswell tacaswell merged commit adf4666 into matplotlib:master Feb 23, 2015
@tacaswell
Copy link
Member

Fair enough, merged. It is only the travis related testing code so I am not super worried about it taking some thrashing on master to get sorted out.

@matthew-brett
Copy link
Contributor Author

Thanks for the merge.

Looking at the travis-ci page : https://travis-ci.org/matplotlib/matplotlib/builds - the merge triggered no build. Do merges to trunk trigger travis-ci builds? Now I think about it, I think travis-ci tests the merge commit of the PR into trunk, so, if you press the green merge button, unless trunk has changed since the PR was tested, travis-ci will not test the merge commit again (because it has tested it already).

I wonder how to test only commits that get merged into trunk (and, I suppose, rerun tests that that have already been run on the PR)?

@tacaswell
Copy link
Member

Part of the problem is that our builds had been turned off on Travis (not
sure how or why, but it is fixed now) this should get triggered next time
that something gets merged to master.

On Mon, Feb 23, 2015, 15:18 Matthew Brett notifications@github.com wrote:

Thanks for the merge.

Looking at the travis-ci page :
https://travis-ci.org/matplotlib/matplotlib/builds - the merge triggered
no build. Do merges to trunk trigger travis-ci builds? Now I think about
it, I think travis-ci tests the merge commit of the PR into trunk, so, if
you press the green merge button, unless trunk has changed since the PR was
tested, travis-ci will not test the merge commit again (because it has
tested it already).

I wonder how to test only commits that get merged into trunk (and, I
suppose, rerun tests that that have already been run on the PR)?


Reply to this email directly or view it on GitHub
#4138 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants