Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up matplotlib.colors #4149

Merged
merged 2 commits into from Mar 1, 2015
Merged

Clean up matplotlib.colors #4149

merged 2 commits into from Mar 1, 2015

Conversation

alanhdu
Copy link
Contributor

@alanhdu alanhdu commented Feb 24, 2015

Various code cleanups to matplotlib.colors. There are a couple places where the logic is changed, although I'm reasonably sure the old logic was wrong:

  • Original line 484 (return np.clip(lut, 0, 1) instead of just lut)
  • Original line 460 and to or
  • Original line 1204 value to val (which is ma.asarray(value)).

@efiring
Copy link
Member

efiring commented Feb 28, 2015

@alanhdu, I think the PEP-8 fixes were handled in #4155. Would you revise this, please, to include only the bug fixes, so it will merge cleanly? We would also like to see a green light from Travis.

@alanhdu
Copy link
Contributor Author

alanhdu commented Mar 1, 2015

@efiring Done.

efiring added a commit that referenced this pull request Mar 1, 2015
Clean up matplotlib.colors
@efiring efiring merged commit 793e52a into matplotlib:master Mar 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants