ENH better error message for wrong fontsize #4159
Conversation
NelleV
added
Documentation
status: needs review
and removed
status: needs review
Documentation
labels
|
👍 |
| @@ -899,7 +899,9 @@ def set_size(self, size): | |||
| size = float(size) | |||
| except ValueError: | |||
| if size is not None and size not in font_scalings: | |||
| raise ValueError("size is invalid") | |||
| raise ValueError( | |||
| "Size is invalid. Valid font size are" + ", ".join( | |||
There was a problem hiding this comment.
super picky: I think you need a trailing space after 'are' and I don't think you need the [] in the generator.
There was a problem hiding this comment.
Don't you need [] for python 2.6 ?
There was a problem hiding this comment.
Oh, maybe. Ignore my comment if that is the case.
There was a problem hiding this comment.
I just tested and it works without it.
There was a problem hiding this comment.
I think so. I can't remember. Better safe than sorry.
On Wed, Feb 25, 2015 at 12:13 PM, Thomas A Caswell <notifications@github.com
wrote:
In lib/matplotlib/font_manager.py
#4159 (comment):@@ -899,7 +899,9 @@ def set_size(self, size):
size = float(size)
except ValueError:
if size is not None and size not in font_scalings:
raise ValueError("size is invalid")raise ValueError("Size is invalid. Valid font size are" + ", ".join(Oh, maybe. Ignore my comment if that is the case.
—
Reply to this email directly or view it on GitHub
https://github.com/matplotlib/matplotlib/pull/4159/files#r25358324.
When the fontsize provided is unknown to matplotlib, the error raised now contains the list of known fontsize.
|
Everything is fixed. |
|
Thanks! I'll merge as soon as travis finishes. |
ENH better error message for wrong fontsize
When the fontsize provided is unknown to matplotlib, the error raised now
contains the list of known fontsize.