Fix Gtk3 Backend Source ID was not found #4164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a reference to the Gtk3 source created by GLib.idle_add so it can be checked to see if it was destroyed later to avoid removing an invalid source id and causing warning messages to be displayed.
|
Seems reasonble to me @fariza any comment? |
|
👍 I see no problem with this. Thanks for the fix |
tacaswell
added a commit
that referenced
this pull request
Feb 25, 2015
Fix : Gtk3 Backend Source ID was not found
|
Thanks! I wonder if this will also fix #3690 |
|
Awesome, thank you both for the quick turnaround! |
|
erm, never mind on that other issue, that is WX, not gtk... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using matplotlib in a GTK3 application (backend is set to GTK3Cairo) and when my application exits I consistently get the following warning:
Looking into the issue it looks like the idle_event is removed and thus when
GLib.source_removeis called, the event id no longer exists. It would be great if a check could take place before the event source is removed to determine if it is still valid.This PR adds a reference to the Gtk3 source created by GLib.idle_add so it can be checked to see if it was destroyed later to avoid removing an invalid source id and causing the aforementioned warning messages to be displayed.