Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mock, coverage and pep8 dep. Added pep8 options #4234

Merged
merged 1 commit into from Mar 17, 2015

Conversation

montefra
Copy link
Contributor

I've added mock as mandatory dependency for python < 3.3 and coverage and pep8 as optional one. I've also added the pep8 options that I've found this morning in the tests.py script.

@montefra
Copy link
Contributor Author

why does the second call of tests.py is

python ../matplotlib/tests.py -sv --processes=5 --process-timeout=300

and not

python tests.py -sv --processes=5 --process-timeout=300

like the first one?

@pelson
Copy link
Member

pelson commented Mar 17, 2015

Thanks @montefra. Why are mock and pep8 considered mandatory dependencies? Both are 100% (optional?) test dependencies, but neither should be used in the non-test codebase.

@montefra
Copy link
Contributor Author

@pelson: mock is mandatory for testing if one uses python < 3.3, so I have added it after the nose entry. coverage and pep8 are optional and I've added them after:

Optionally you can install:

Why are mock and pep8 considered mandatory dependencies? Both are 100% (optional?) test dependencies, but neither should be used in the non-test codebase.

What do you mean? I've edited only testing.rst, I haven't added mock, coverage or pep8 anywhere else.

@jenshnielsen
Copy link
Member

@pelson Mock is actually used to build the docs at this stage to avoid pulling in additional dependencies when running autodoc. I should probably improve the documentation to reflect that.

@tacaswell tacaswell added this to the next point release milestone Mar 17, 2015
@montefra
Copy link
Contributor Author

If the commit is accepted, would it make sense to also have a message in setupext:Tests if coverage and/or pep8 are not installed?

@pelson
Copy link
Member

pelson commented Mar 17, 2015

What do you mean? I've edited only testing.rst, I haven't added mock, coverage or pep8 anywhere else.

My apologies, the PR title does not reflect what you have done. I'm 👍 with this change as it is.

tacaswell added a commit that referenced this pull request Mar 17, 2015
DOC : improve documentation of testing dependencies
@tacaswell tacaswell merged commit be6a691 into matplotlib:master Mar 17, 2015
@montefra montefra deleted the testing_doc branch March 22, 2015 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants