Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC : start to move MEP to docs #4249

Merged
merged 3 commits into from Mar 27, 2015
Merged

Conversation

tacaswell
Copy link
Member

Moved template and MEP25.

If people think this is a good idea, we can move the rest of them over
from the wiki as well.

@mdboom
Copy link
Member

mdboom commented Mar 19, 2015

I have no real strong objection. I thought the wiki might be a lower barrier of entry to contributing, but maybe I'm wrong -- there hasn't been a lot of collaborative editing of MEPs anyway.

@tacaswell tacaswell added this to the next point release milestone Mar 19, 2015
@tacaswell
Copy link
Member Author

I think the main downside of the wiki is that you can't leave line comments so discussion is only through the edits which I have a hard time following. I really like the emails/github notifications for keeping track of when things change.

I am a bit less concerned about the barrier for entry as many of the people who would work on MEPs are already involved in the project.

@fariza
Copy link
Member

fariza commented Mar 23, 2015

What would be the workflow for the the MEPs? like a normal PR?

@tacaswell
Copy link
Member Author

@fariza Yes

@fariza
Copy link
Member

fariza commented Mar 26, 2015

I understand the need for a better comment tracking in the MEPs, but from experience, when implementing a MEP, sometimes the implementation changes along the way, so the MEP document has to be modified also.
If the document has been merged, then another PR has to be made for the changes and wait to be merged....
Unless, you wait for the final implementation and merge of the PRs for the MEP PR to be merged.

@tacaswell
Copy link
Member Author

This way if the MEP does change it will get more attention, rather than the
wiki silently changing. If there are major changes it is probably a good
thing if it forces a PR and discussion.

I expect the MEP text change PRs will go much faster than code PRs.

On Thu, Mar 26, 2015 at 9:19 AM Federico Ariza notifications@github.com
wrote:

I understand the need for a better comment tracking in the MEPs, but from
experience, when implementing a MEP, sometimes the implementation changes
along the way, so the MEP document has to be modified also.
If the document has been merged, then another PR has to be made for the
changes and wait to be merged....
Unless, you wait for the final implementation and merge of the PRs for the
MEP PR to be merged.


Reply to this email directly or view it on GitHub
#4249 (comment)
.

@fariza
Copy link
Member

fariza commented Mar 26, 2015

I agree that we need more discussion and that outweighs my other concerns
👍

Moved template and MEP25.

If people think this is a good idea, we can move the rest of them over
from the wiki as well.
@tacaswell
Copy link
Member Author

@matplotlib/developers Can this get an up or down soonish?

@jenshnielsen
Copy link
Member

Im fine with it now that we have an automatic build of the docs so that it is visible on matploblib.org

@WeatherGod
Copy link
Member

+1 from me

On Thu, Mar 26, 2015 at 10:16 AM, Jens Hedegaard Nielsen <
notifications@github.com> wrote:

Im fine with it now that we have an automatic build of the docs so that it
is visible on matploblib.org


Reply to this email directly or view it on GitHub
#4249 (comment)
.

@mdboom
Copy link
Member

mdboom commented Mar 26, 2015

👍 from me.

@OceanWolf
Copy link
Contributor

👍 I find myself agreeing with everything said here. I don't see implementation changes as an issue, one can change the MEP doc and the actual consequences to the codebase of that change in a single PR which I think makes it even easier to see what goes on and I believe will add to that collaborative editing of MEPs.

One thing, @tacaswell comparing the two pages for MEP25, the wiki and here, I see that your copy-paste buffer only captured the first half of the MEP... also what happened to the TOC?

@efiring
Copy link
Member

efiring commented Mar 26, 2015

I think it's a good idea. In addition to including the second half of the MEP as noted in @OceanWolf's comment, I suggest running a line-splitter so that text lines have a target length of 60-70 characters.

@tacaswell
Copy link
Member Author

I think I have addressed all of these issues.

Sorry for copy-paste fail.

efiring added a commit that referenced this pull request Mar 27, 2015
DOC : start to move MEP to docs
@efiring efiring merged commit 9348a46 into matplotlib:master Mar 27, 2015
@tacaswell tacaswell deleted the mep_docs branch March 31, 2015 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants