New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC : document exact freetype versions for tests #4345
DOC : document exact freetype versions for tests #4345
Conversation
How do we plan to keep this information up to date? |
Developer good will? If we are very clever we might be able to extract the Travis version as On Thu, Apr 16, 2015, 15:42 Benjamin Root notifications@github.com wrote:
|
eh, good will or no, I see this going south pretty quickly. Also, we don't package images generated from Travis anyway. Doesn't our unit tests record which version of freetype is used in order to mark some tests as skipped? |
The case that prompted this was a question in #4342 which is having un-explained failures on travis (maybe due to freetype version issues). Having this documented someplace other than an issue commit is a good thing, even if we risk it getting out of date. |
|
||
Due to subtle differences in the font rendering under different | ||
version of freetype some care must be taken when generating the | ||
baseline images. Currently, almost all of the images were generated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Currently (2015)"
It might be a good idea to document when currently is? To make it more obvious if this is out of date
Document what version of freetype was used to generate baseline images in PR matplotlib#4031 / commit 005cfde and which version is (currently) being run on travis.ci
6641d25
to
bc4cf9a
Compare
Updated and squashed. |
DOC : document exact freetype versions for tests
Document what version of freetype was used to generate baseline
images in PR #4031 / commit
005cfde and which version is
(currently) being run on travis.ci