Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC : document exact freetype versions for tests #4345

Merged

Conversation

tacaswell
Copy link
Member

Document what version of freetype was used to generate baseline
images in PR #4031 / commit
005cfde and which version is
(currently) being run on travis.ci

@WeatherGod
Copy link
Member

How do we plan to keep this information up to date?

@tacaswell
Copy link
Member Author

Developer good will?

If we are very clever we might be able to extract the Travis version as
part of the automated build process.

On Thu, Apr 16, 2015, 15:42 Benjamin Root notifications@github.com wrote:

How do we plan to keep this information up to date?


Reply to this email directly or view it on GitHub
#4345 (comment)
.

@WeatherGod
Copy link
Member

eh, good will or no, I see this going south pretty quickly. Also, we don't package images generated from Travis anyway. Doesn't our unit tests record which version of freetype is used in order to mark some tests as skipped?

@tacaswell
Copy link
Member Author

The case that prompted this was a question in #4342 which is having un-explained failures on travis (maybe due to freetype version issues). Having this documented someplace other than an issue commit is a good thing, even if we risk it getting out of date.


Due to subtle differences in the font rendering under different
version of freetype some care must be taken when generating the
baseline images. Currently, almost all of the images were generated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Currently (2015)"

It might be a good idea to document when currently is? To make it more obvious if this is out of date

Document what version of freetype was used to generate baseline
images in PR matplotlib#4031 / commit
005cfde and which version is
(currently) being run on travis.ci
@tacaswell tacaswell force-pushed the doc_freetype_img_test_version branch from 6641d25 to bc4cf9a Compare April 18, 2015 15:50
@tacaswell
Copy link
Member Author

Updated and squashed.

WeatherGod added a commit that referenced this pull request Apr 20, 2015
DOC : document exact freetype versions for tests
@WeatherGod WeatherGod merged commit dba7626 into matplotlib:master Apr 20, 2015
@tacaswell tacaswell deleted the doc_freetype_img_test_version branch April 20, 2015 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants