Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label outer offset text #4446

Merged
merged 2 commits into from Mar 26, 2016
Merged

Label outer offset text #4446

merged 2 commits into from Mar 26, 2016

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 20, 2015

Partial fix for #4445: hide the offset text when using label outer. Also slightly saner(?) implementation of check_{shared,visible} in the tests.

@tacaswell
Copy link
Member

Any guesses what is causing that failure? That is an unexpected one...

@tacaswell tacaswell added this to the next point release milestone May 21, 2015
@anntzer
Copy link
Contributor Author

anntzer commented May 21, 2015

I have no idea. I am unable to run the entire test suite locally due to some (unrelated) LaTeX error but I did make sure that the tests I wrote pass...

@tacaswell tacaswell modified the milestones: proposed next point release, next point release Jun 17, 2015
@tacaswell
Copy link
Member

Moved to 'proposed next point release' meaning that this will not be a blocker for the next point release, but will go in if it is ready, as this is failing the tests and has had no activity for a month.

@anntzer
Copy link
Contributor Author

anntzer commented Jun 17, 2015

Can you try to reproduce the test failure locally? Here, for me, test_diff_cell_table passes fine, so I have no idea of what is happening.

@tacaswell
Copy link
Member

I also can not reproduce this, kicked travis to restart.

@tacaswell tacaswell closed this Mar 22, 2016
@tacaswell tacaswell reopened this Mar 22, 2016
@tacaswell
Copy link
Member

It looks like the test_shared test is missing a @cleanup. My guess is that somehow the addition of the second figure in that test is what is causing trouble?

@anntzer
Copy link
Contributor Author

anntzer commented Mar 22, 2016

Well, the tests seemed to be passing at least on 3.5, but adding an @clenaup can't hurt so I just amended the second commit.

@tacaswell
Copy link
Member

The dispatching on the multiprocess may not be deterministic.

@anntzer
Copy link
Contributor Author

anntzer commented Mar 22, 2016

Ouch!

@tacaswell tacaswell merged commit 448d9ed into matplotlib:master Mar 26, 2016
@anntzer anntzer deleted the label_outer-offsetText branch May 11, 2016 18:31
@anntzer anntzer mentioned this pull request Jun 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anntzer @tacaswell