ENH: pass dash_offset through to gc for Line2D

[tacaswell]

Previously, the user supplied offset to Line2D set_linestyle
was silently discarded. This commit makes the value to be passed
through to the underlying GC on draw, but not all of the backends do
anything with the offset (ex Agg does not).

[mdboom]

See my enh_dashoffset branch. I fixed the Agg backend and the PostScript backend. All other backends seemed to already work. (Can't make PR against this because we have too many forks and I can't set yours as the base ?!?)

We should add a test based on your example in #5430.

[tacaswell]

We have emailed gh about that issue, we are just too big. The work around
is url hacking as the bug is in generating the drop down menu.

On Thu, Nov 12, 2015, 09:02 Michael Droettboom notifications@github.com
wrote:

See my enh_dashoffset branch. I fixed the Agg backend and the PostScript
backend. All other backends seemed to already work. (Can't make PR against
this because we have too many forks and I can't set yours as the base ?!?)

We should add a test based on your example in #5430
#5430.

—
Reply to this email directly or view it on GitHub
#5433 (comment)
.

[tacaswell]

I think this is ready to go.

[mdboom]

Backported to 2.0.x as d11e344

[afvincent]

In test_dash_offset(), is it normal to have plt.show() at the end of the test? I just ask this because when I run test_axes in an IPython session, it is the only test that plots something on my screen (and waits for me to close the window to finish the other tests, as plt.ion() is not used).

[tacaswell]

That can probably be removed.