Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs / examples fixes. #5870

Merged
merged 1 commit into from Jan 24, 2016
Merged

Docs / examples fixes. #5870

merged 1 commit into from Jan 24, 2016

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 17, 2016

examples/axes_grid1/parasite_simple2.py

See #5864 for the weirdness before the fix.

After the fix (master / 1.5.0):
screenshot_20160117_114835
screenshot_20160117_114907

@tacaswell tacaswell added this to the Critical bug fix release (1.5.2) milestone Jan 17, 2016
@anntzer anntzer changed the title Proper typing of "prime" in docs Docs / examples fixes. Jan 18, 2016
@anntzer
Copy link
Contributor Author

anntzer commented Jan 18, 2016

Bundling in an unrelated broken link fix.

@mdboom
Copy link
Member

mdboom commented Jan 18, 2016

I think the failure is unrelated (we've seen it creep up in other PRs).

👍 from me otherwise, though.

@zblz
Copy link
Member

zblz commented Jan 19, 2016

@anntzer - I fixed the arcsecond thing in #5880, so now $''/yr$ should parse correctly (as in TeX). I'm not sure whether it's worth making the change to \prime if it will get typeset correctly (eventually) as it is now.

@anntzer
Copy link
Contributor Author

anntzer commented Jan 19, 2016

Then I'd still need to change $^{''}$ to $''$ right? A quick check with usetex=True tells me $^{''}$ is even smaller (which makes sense as $'$ is $^\prime$ and \prime is a larger version of ').

@zblz
Copy link
Member

zblz commented Jan 19, 2016

Yes! I did not realize the original was $^{''}$, that definitely makes no sense.

- Proper typing of "prime" in docs, see matplotlib#5864.
- Update broken link.
jenshnielsen added a commit that referenced this pull request Jan 24, 2016
@jenshnielsen jenshnielsen merged commit 12e0878 into matplotlib:master Jan 24, 2016
jenshnielsen added a commit that referenced this pull request Jan 24, 2016
@jenshnielsen
Copy link
Member

Thanks Backported to 1.5.x as 6405839

@anntzer anntzer deleted the doc-typo branch January 24, 2016 15:44
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants