Some small cleanups based on Quantified code #6154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skimming through seems like the other things it finds have reasonable signal-to-noise. |
|
My main problem with enabling it on PR's is that it seems to detect new issues in a PR in parts of the code that has't been touched so I am worried about false failures |
|
This needs a rebase |
Fortunatly they are all the same in different representations
Original code could never run
jenshnielsen
force-pushed
the
quantifiedcodecleanup
branch
from
88484e2
to
09aba5b
Compare
| import numpy as np | ||
| import matplotlib.pyplot as plt | ||
| plt.rcdefaults() |
There was a problem hiding this comment.
If you're going to move this down here, it should have two blank lines above and one blank line after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing out Quantified code on Matplotlib here
I'm not sure we want to enable that in general but I found a few issues worth fixing here: