Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements concerning #6353 and #6357 #6386

Merged
merged 4 commits into from May 9, 2016
Merged

Minor improvements concerning #6353 and #6357 #6386

merged 4 commits into from May 9, 2016

Conversation

khyox
Copy link
Contributor

@khyox khyox commented May 8, 2016

Related with #6353 and #6357, this commit corrects ylabel string in histogram_demo_features.py example but also tries to improve the documentation of hist in pyplot to clarify which one of the two common ways to normalize the counts is available through this option and which is not, in order to avoid future misunderstandings.

khyox added 2 commits May 6, 2016 19:59
Extend the description about the normed option for histograms (hist) to clarify which one of the two common ways to normalize the counts is available through this option and which is not.
@tacaswell
Copy link
Member

power-cycled to re-run CI against current master (which has had some un-related fixes applied).

``n/(len(x)`dbin)``, i.e., the integral of the histogram will sum
to 1. If *stacked* is also *True*, the sum of the histograms is
normalized to 1.
the integral of the histogram will sum to 1. So, the normalized
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you flip this sentence to say what it is first (before saying what it is not) and make it a bit terser?

Can we assume are audience knows calculus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, Thomas, no problem flipping it. Anyway, these two normalization methods of histograms are somehow like miles and kilometers, in the sense that you can say 'Hey, this is not in kilometers, this is in miles'. I can also switch 'the integral of the histogram will sum to 1' to 'the area (or integral) under the histogram will sum to one'.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it is right now from your point of view. I flipped and shortened the explanation. I think it is in the limit to be useful to avoid new confusion about the normalization method that is applied. Thanks.

Tries to introduce the suggestions of Thomas in #6386.
@jenshnielsen
Copy link
Member

The remaining issue on Travis is a whitespace issue from pep8

/home/travis/build/matplotlib/matplotlib/lib/matplotlib/axes/_axes.py:5807:73: W291 trailing whitespace

Correct pep8 deviation in _axes.py:5807:73: W291 trailing whitespace
@khyox
Copy link
Contributor Author

khyox commented May 9, 2016

Many thanks @jenshnielsen! It should be right now. Let us see the result of the tests...

@tacaswell tacaswell merged commit aeb6112 into matplotlib:master May 9, 2016
@tacaswell
Copy link
Member

Thanks!

@khyox
Copy link
Contributor Author

khyox commented May 9, 2016

@tacaswell, @jenshnielsen: Sorry, I know I made this a bit painful! 😌 Thank you for your patience and help! 😉

@tacaswell
Copy link
Member

Thank you for being patient with us.

@QuLogic QuLogic added this to the 2.1 (next point release) milestone May 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants