Added a new example to create error boxes using a PatchCollection #6596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this! Can you run this through a pep8 linter? closes #6593 |
|
No problem, I think that should be ok now? |
| def makeErrorBoxes(xdata, ydata, xerror, yerror, fc='r', ec='None', alpha=0.5): | ||
| ''' | ||
| Function to create error boxes | ||
| ''' |
There was a problem hiding this comment.
I forget, did we want examples to have functions like this when it is just being called once? I thought it was only desirable to do for the examples to de-duplicate code?
There was a problem hiding this comment.
I agree, in such a short example, there's not much benefit to this function, and there are more than enough comments to make it clear what all the code is doing.
|
Some suggestions (partially rendundant with other comments):
|
|
does this get backported anywhere? |
|
I think it should go into 2.x too |
WeatherGod
added a commit
that referenced
this pull request
Jul 14, 2016
Added a new example to create error boxes using a PatchCollection
|
backported to v2.x via 9ea7315 |
QuLogic
modified the milestones:
2.0 (style change major release),
2.1 (next point release)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new example I first created here: http://stackoverflow.com/a/37856171/588071