Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash if byte-compiled level 2 #6729

Merged
merged 3 commits into from Jul 12, 2016
Merged

Fix crash if byte-compiled level 2 #6729

merged 3 commits into from Jul 12, 2016

Conversation

JGoutin
Copy link
Contributor

@JGoutin JGoutin commented Jul 12, 2016

Follow #6719

@JGoutin JGoutin mentioned this pull request Jul 12, 2016
Closed
@JGoutin
Print byte-compilation level for debug
5f395e0 
Help see if `.travis.yml` work as intended.
@QuLogic QuLogic added this to the 2.1 (next point release) milestone Jul 12, 2016
@JGoutin
Copy link
Contributor Author

JGoutin commented Jul 12, 2016

The Travis test with -OO work as intended.

And, tests completed without error. There is no other crash like this.

@tacaswell
Copy link
Member

👍 Thanks

@QuLogic
Copy link
Member

QuLogic commented Jul 12, 2016

You've only added -OO to the test run. Does the -OO actually apply to the matplotlib files that are already installed?

@tacaswell
Copy link
Member

From reading the docs, it will regenerate the byte code if needed.

@tacaswell tacaswell closed this Jul 12, 2016
@tacaswell tacaswell reopened this Jul 12, 2016
@tacaswell tacaswell merged commit cb00f0b into matplotlib:master Jul 12, 2016
@tacaswell
Copy link
Member

Sorry, clicked the wrong button.

@JGoutin JGoutin deleted the patch-1 branch July 13, 2016 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JGoutin @tacaswell @QuLogic @mdboom