Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xkcd font as one of the options #6811

Merged
merged 3 commits into from Jul 23, 2016
Merged

Add xkcd font as one of the options #6811

merged 3 commits into from Jul 23, 2016

Conversation

peterfpeterson
Copy link
Contributor

The official xkcd font https://github.com/ipython/xkcd-font
was missing from the list of what is looked for when the
user selects xkcd mode. Since it is the "official" font, it
has been added to the top of the list.

@peterfpeterson
Add xkcd font as one of the options
cb11f27 
The official xkcd font https://github.com/ipython/xkcd-font
was missing from the list of what is looked for when the
user selects xkcd mode. Since it is the "official" font, it
has been added to the top of the list.
@tacaswell
Copy link
Member

Does this correctly use the font if it is installed?

@tacaswell tacaswell mentioned this pull request Jul 22, 2016
Closed
@afvincent afvincent mentioned this pull request Jul 22, 2016
Closed
@jenshnielsen
Copy link
Member

This should probably also be added to
font.fantasy in the template

https://github.com/matplotlib/matplotlib/blob/master/matplotlibrc.template#L209

and rcsetup

https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/rcsetup.py#L1002

@peterfpeterson
Copy link
Contributor Author

I installed the font in my ~/.fonts directory and it works beautifully. Should I modify this PR to include the changes @jenshnielsen suggested?

@tacaswell
Copy link
Member

Yes please.

@tacaswell tacaswell added this to the 2.0 (style change major release) milestone Jul 22, 2016
tacaswell
tacaswell reviewed Jul 22, 2016
View reviewed changes
lib/matplotlib/rcsetup.py
@@ -1000,7 +1000,7 @@ def validate_animation_writer_path(p):
'Sand', 'Script MT', 'Felipa', 'cursive'],
validate_stringlist],
'font.fantasy': [['Comic Sans MS', 'Chicago', 'Charcoal', 'Impact'
'Western', 'Humor Sans', 'fantasy'],
'Western', 'Humor Sans', 'fantasy, xkcd'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong, are there missing '' here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully build servers pick that one up.

@tacaswell tacaswell merged commit 64ad40b into matplotlib:master Jul 23, 2016
tacaswell added a commit that referenced this pull request Jul 23, 2016
@tacaswell
Merge pull request #6811 from peterfpeterson/xkcd_font
8751f9b 
ENH: Add xkcd font as one of the options in xkcd style
@tacaswell
Copy link
Member

Backported to 2.x as 8751f9b

Thanks @peterfpeterson

@QuLogic
Copy link
Member

QuLogic commented Jul 23, 2016

Hmm, isn't fantasy a meta-name for fonts and should be last?

@tacaswell
Copy link
Member

it is very possible I screwed up here.

QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Oct 16, 2016
@QuLogic
Ensure meta font names are listed last.
cba07e2 
cf. last comments on matplotlib#6811.
@QuLogic QuLogic mentioned this pull request Oct 16, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@peterfpeterson @tacaswell @jenshnielsen @QuLogic @mdboom