Tick label rotation via set_tick_params
#6829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,6 +73,7 @@ def __init__(self, axes, loc, label, | |||
| pad=None, | |||
| labelsize=None, | |||
| labelcolor=None, | |||
| labelrotation=0, | |||
There was a problem hiding this comment.
Please put last so to preserve API
|
Can you add a test? I don't think this needs an image test, just verify that the rotation value ends up correctly on the tick labels. |
bcongdon
force-pushed
the
feature_improved_tick_label_rotation
branch
from
5191ca8
to
a755218
Compare
|
I added this test to do assertion of label rotation. Is that sufficient? |
|
👍 Looks great. Just waiting on CI. |
|
Sorry, one last thing, can you also update the docstrings in |
|
Yup, done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6795.
Implemented @tacaswell's suggestion so that commands such as
ax.xaxis.set_tick_params(which='both', rotation=90)are now possible.Added related test and whats_new entry.