New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify Axes.hexbin *extent* docstring #6842
Conversation
@unpack_labeled_data(replace_names=["y", "x1", "x2", "where"], | ||
label_namer=None) | ||
@unpack_labeled_data(replace_names=['y', 'x1', 'x2', 'where'], | ||
label_namer=none) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this working?
I noticed the None/none variance in several places, but didn't think I touched any of them. And you are right, somehow I missed that last one. I will look into the None/none issue and fix that quote tomorrow. I knew my first PR was going to have some silly mistakes! |
Looks like there are a bunch of pep8 whitespace related issues.
the enforcement of pep8/pycodestyle is annoying, but long term it is very helpful in a codebase with many people touching the code. |
else: | ||
raise ValueError("Using arbitrary long args with data is not " | ||
"supported due to ambiguity of arguments.\nUse " | ||
raise ValueError("Using arbitrary long args with data is not " \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the \
based on *gridsize*, *x*, *y*, *xscale* and *yscale*. | ||
|
||
If *xscale* or *yscale* is set to 'log', the limit is | ||
expected as a power of 10. E.g. for x-limits of 1 and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚲 🏠 Should this be '..the limits are the power to raise 10 to to compute the range of the bins.'? I would read 'expected as a power of 10' to mean the inputs must be of the form [10, 100, 1000, ...].
The documentation changes seem very good, however it is greatly obscured by the changes to the quotes. Would it be possible to separate those two sets of changes? |
Without looking at the source, it was unclear that *extent* expects the limites to be given as exponents of powers of 10 if the axis scale is set to 'log'. E.g., using 3 to represent 1000. Removed superfluous style change commits. Will open separate pull request for that. Resolves: matplotlib#6479
852018f
to
bed7c7b
Compare
This was definitely a learning experience. I had to learn a lot about git, virtual environments, building/installing, testing. Yowza. And I definitely learned the importance of splitting up PRs. Thanks for the patience guys. |
@LindyBalboa Everyone starts someplace! Sorry the learning curve was steep. |
DOC: Clarify Axes.hexbin *extent* docstring
backported to v2.x as 2811640 |
@LindyBalboa Thank you (and thank you for going through the learning curve!) Documentation is drastically undervalued and we very much appreciate your work on this. I think this is your first contribution to mpl. Congratulation 🎉 and hopefully we will hear from you again soon! |
Without looking at the source, it was unclear that extent expects the
limits to be given as powers of ten if the axis scale is set to 'log'.
E.g., using 3 to represent 1000.
Also went through the file and standardized quote usage.
Resolves: #6479