Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sankey.py pep8 and py3 compatibility #973

Merged
merged 3 commits into from Jul 18, 2012
Merged

Fix sankey.py pep8 and py3 compatibility #973

merged 3 commits into from Jul 18, 2012

Conversation

cgohlke
Copy link
Contributor

@cgohlke cgohlke commented Jun 30, 2012

No description provided.

@pelson
Copy link
Member

pelson commented Jun 30, 2012

I've gone through these changes and they are fine. I have made similar stylistic improvements in the past, but we do need to be careful in making large scale changes to files whilst we have the v1.1.x branch in a non-frozen state (see #910).

This gets my +1.

@cgohlke
Copy link
Contributor Author

cgohlke commented Jun 30, 2012

That's a good point (making large scale changes). This could wait until after 1.1.1.

@pelson
Copy link
Member

pelson commented Jun 30, 2012

This could wait until after 1.1.1.

Lets do that. That is a whole other issue which I intend to bring up in the next couple of days :-)

@mdboom
Copy link
Member

mdboom commented Jul 1, 2012

I agree about holding off on this until the 1.1.1 release.

It might also be nice, if possible, to separate out the actual fixes for Python 3 from the general PEP8 stuff.

@WeatherGod
Copy link
Member

Now that v1.1.1 is out, would it be safe to get this merged in?

@pelson
Copy link
Member

pelson commented Jul 18, 2012

@WeatherGod: If your happy with the changes too, then I would say nothing.

@WeatherGod
Copy link
Member

ok, merging....

WeatherGod added a commit that referenced this pull request Jul 18, 2012
Fix sankey.py pep8 and py3 compatibility
@WeatherGod WeatherGod merged commit 11567bb into matplotlib:master Jul 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants