@@ -266,10 +266,12 @@ module ActiveRecord def related_search_options(context, klass, options = {}) tags_to_find = self.tags_on(context).collect { |t| t.name } + + exclude_self = "#{klass.table_name}.id != #{self.id} AND" if self.class == klass { :select => "#{klass.table_name}.*, COUNT(#{Tag.table_name}.id) AS count", :from => "#{klass.table_name}, #{Tag.table_name}, #{Tagging.table_name}", - :conditions => ["#{klass.table_name}.id = #{Tagging.table_name}.taggable_id AND #{Tagging.table_name}.taggable_type = '#{klass.to_s}' AND #{Tagging.table_name}.tag_id = #{Tag.table_name}.id AND #{Tag.table_name}.name IN (?)", tags_to_find], + :conditions => ["#{exclude_self} #{klass.table_name}.id = #{Tagging.table_name}.taggable_id AND #{Tagging.table_name}.taggable_type = '#{klass.to_s}' AND #{Tagging.table_name}.tag_id = #{Tag.table_name}.id AND #{Tag.table_name}.name IN (?)", tags_to_find], :group => "#{klass.table_name}.id", :order => "count DESC" }.update(options) lib/acts_as_taggable_on/acts_as_taggable_on.rb @@ -103,6 +103,20 @@ describe "Acts As Taggable On" do taggable1.find_related_tags_for(OtherTaggableModel).should include(taggable3) taggable1.find_related_tags_for(OtherTaggableModel).should_not include(taggable2) end + + it "should not include the object itself in the list of related objects" do + taggable1 = TaggableModel.create!(:name => "Taggable 1") + taggable2 = TaggableModel.create!(:name => "Taggable 2") + + taggable1.tag_list = "one" + taggable1.save + + taggable2.tag_list = "one, two" + taggable2.save + + taggable1.find_related_tags.should include(taggable2) + taggable1.find_related_tags.should_not include(taggable1) + end end describe 'Tagging Contexts' do spec/acts_as_taggable_on/acts_as_taggable_on_spec.rb 7fe16ba64c2cabae924b2906a47946643712ee6d Luke Francl luke@skywalker.local http://github.com/mbleigh/acts-as-taggable-on/commit/b72efd05ff6a71c573e8edf983e4c00d27f3d8fc b72efd05ff6a71c573e8edf983e4c00d27f3d8fc 2009-02-03T16:55:45-08:00 2008-12-08T16:22:04-08:00 add a condition so the model being related to isn't itself returned in the search results. Signed-off-by: Michael Bleigh <michael@intridea.com> b9427946e2e4d9b2a9bb6802b5e5997cd9137fcf Michael Bleigh michael@intridea.com