mbleigh / acts-as-taggable-on

Is anyone else seeing this?

When I pass tagged_with a tag that does not exist, it returns every record (instead of none).

>> Website.tagged_with("some tag that does not exist", :on=>:tags).size
=> 239
>> Website.count
=> 239

Hi,
is it possible to support friendly url like in this gem http://github.com/norman/friendly_id ?
Name of the tag instead of the id in the url (and in the searching etc.)
Thanks
Petr

Hello,

why the gem doesn't embed the generator ?

Thanks
Franck

With this model code:

acts_as_taggable_on :categories

I get a model that supports self.categories. The tag context acts kind of like a has_many association. Good.

But when I add:

accepts_nested_attributes_for :categories

and POST a list of categories to the create action I get this exception deep in AR#new:

1)
ActiveRecord::AssociationTypeMismatch in 'PlacesController authenticated user should process categories parameter to create'
Tag(#2176796520) expected, got String(#2148246520)
/Library/Ruby/Gems/1.8/gems/activerecord-2.3.4/lib/active_record/associations/association_proxy.rb:263:in raise_on_type_mismatch' /Library/Ruby/Gems/1.8/gems/activerecord-2.3.4/lib/active_record/associations/association_collection.rb:320:inreplace' /Library/Ruby/Gems/1.8/gems/activerecord-2.3.4/lib/active_record/associations/association_collection.rb:320:in each' /Library/Ruby/Gems/1.8/gems/activerecord-2.3.4/lib/active_record/associations/association_collection.rb:320:inreplace' /Library/Ruby/Gems/1.8/gems/activerecord-2.3.4/lib/active_record/associations.rb:1322:in `categories='

It appears that the association is looking for Tag objects and won't accept the Strings I'm handing it.

Hello mbleigh,

Can you move the gem to gemcutter.org?

http://gems.github.com/ doesn't work anymore :)

Thanks

As pointed out by Stuart Henry https://mbleigh.lighthouseapp.com/projects/10116-acts-as-taggable-on/tickets/49-add-count-column-to-tags-table#ticket-49-2, the count column is not included in acts_as_taggable_on_migration. Consequently, tag counts aren't returned for User.skill_counts, etc.

To fix after the fact create a migration that includes the following:
add_column :tags, :count, :integer, :default => 0

when merging conditions string parentheses should be placed around clauses with OR.
Example:

currently User.tagged_with("foo, bar", :as => :languages) will result in the following query:
SELECT .... WHERE (context = 'languages' AND users_tags.name LIKE 'foo' OR users_tags.name LIKE 'bar')

Note that it will improperly match 'bar' tag in any context.

As shown below, chaining the tagged_with named scope doesn't appear to work, at least not in the way I'm doing it. What nomenclature do I used to find all Products that are tagged with both "081" and "20x24"?

Thanks.
c.

>> Product.find(1).tags.map {|t| t.name}
=> ["081", "20x24", "aluminum", "forever", "frame"]
>> Product.tagged_with("081", {}).size
=> 24
>> Product.tagged_with("20x24", {}).size
=> 94
>> Product.tagged_with("20x24, 081", {}).size
=> 118
>> Product.tagged_with("081", {}).tagged_with("20x24", {}).size
=> 0

Subject :)

Not an issue but really, I have a bunch of other plugins in my vendor folder and acts_as_taggable_on is the only one which proudly announces himself in the logs.

When I run a tag seach with :match_all => true I get the following error.

ActiveRecord::StatementInvalid (PGError: ERROR:  column "entries.id" must appear in the GROUP BY clause or be used in an aggregate function
: SELECT DISTINCT entries.* FROM "entries"  LEFT OUTER JOIN taggings entries_taggings ON entries_taggings.taggable_id = entries.id AND entries_taggings.taggable_type = E'Entry' LEFT OUTER JOIN tags entries_tags ON entries_tags.id = entries_taggings.tag_id WHERE ((context = E'tags' AND entries_tags.name LIKE E'abandoned stairs') AND ("entries"."status" = E'published'))  GROUP BY entries_taggings.taggable_id HAVING COUNT(entries_taggings.taggable_id) = 1 ORDER BY published_at DESC LIMIT 30 OFFSET 0):

passed-in conditions are not being sanitized, causing some funky behavior with bound parameters; ex: :conditions => [ "foo.id IN (?)", [1,2,3,4,5] ] is being converted to SQL " foo.id in (?) AND 1 AND 2 AND 3 AND 4 AND 5"

here's a fix I applied that appears to be working:
before:
conditions = [

        taggable_type,
        taggable_id,
        options[:conditions],
        start_at,
        end_at
      ]

after:
conditions = [

        taggable_type,
        taggable_id,
        sanitize_sql(options[:conditions]),
        start_at,
        end_at
      ]

Hi,

This a great plugin. Here two small bugs.

in : find_options_for_find_tagged_with()
change : conditions << sanitize_sql(["context = ?",on.to_s])
to : conditions << sanitize_sql(["#{Tagging.table_name}.context = ?",on.to_s])

in : find_options_for_tag_counts()
change:
{ :select => "#{Tag.table_name}.id, #{Tag.table_name}.name, COUNT(*) AS count",

        :joins      => joins.join(" "),
        :conditions => conditions,
        :group      => group_by
      }

to :
{ :select => "#{Tag.table_name}.id, #{Tag.table_name}.name, COUNT(*) AS count",

        :joins      => joins.join(" "),
        :conditions => conditions,
        :group      => group_by,
        :order      => options[:order]
      }

Best regards,

miguel cabero

If I call tagged_with without specifying options, I get an exception thrown:

ArgumentError: wrong number of arguments (1 for 2)
from vendor/plugins/acts-as-taggable-on/lib/acts_as_taggable_on/acts_as_taggable_on.rb:90

I just installed the plugin today; this is a Rails 2.3.2 project.

Here's my proposed patch:

named_scope :tagged_with, lambda{ |tags, *options|
  options = options.shift || {}
  find_options_for_find_tagged_with(tags, options)
}