@@ -92,11 +92,9 @@ module ScribdFu # Load, store, and return the associated iPaper document def load_ipaper_document(id) - begin - @document ||= scribd_user.find_document(id) - rescue - raise ScribdFuError, "Scribd Document ##{id} not found!" - end + # Yes, catch-all rescues are bad, but the end rescue + # should return nil, so laziness FTW. + scribd_user.find_document(id) rescue nil end # Replace spaces with '%20' (needed by Paperclip models). lib/scribd_fu.rb @@ -1,7 +1,7 @@ Gem::Specification.new do |s| s.name = "scribd_fu" - s.version = "2.0.3" - s.date = "2009-04-06" + s.version = "2.0.4" + s.date = "2009-04-12" s.summary = "Quick and easy interactions with Scribd's iPaper service" s.email = "matt@matt-darby.com" s.homepage = "http://github.com/mdarby/scribd_fu/tree/master" scribd_fu.gemspec @@ -105,6 +105,10 @@ describe "An AttachmentFu model" do @document.save end + it "should not error out when deleted" do + lambda {@document.destroy}.should_not raise_error(ScribdFu::ScribdFuError) + end + end end spec/scribd_fu_spec.rb 7f1593af1aeb1119db0eca0e974bca2e61931118 Matt Darby matt@matt-darby.com http://github.com/mdarby/scribd_fu/commit/d885f4959f48cbb3c8a11f52f9088ad99dbea98c d885f4959f48cbb3c8a11f52f9088ad99dbea98c 2009-04-12T16:26:39-07:00 2009-04-12T16:26:39-07:00 Refactored #load_ipaper_document to be more permissive 251990c715e39ad1726da033b8b5c1e2073bb845 Matt Darby matt@matt-darby.com