Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, so I found the issue causing this bug: http://github.com/metajack/strophejs/issues#issue/2
If more than one connection is allowed, the terminate/unavailable stanza is sent on a new connection, which gets a terminate response. There is still another open connection, however, so instead of the final part of closing a connection being performed:
We actually consider the terminate response to be a connection error. In order to handle this correctly, we need to cease considering this as an error, by testing if a disconnect is in progress.