@@ -5,7 +5,7 @@ GroupedScope aims to make two things easier in your ActiveRecord models. First, easy way to group objects, second, to allow the group to share associated object via existing has_many relationships. See installation and usage for more details. -By the way, this plugin has been tested with rails 1.2.6, 2.0.4, and 2.1.1. +By the way, this plugin has been tested with rails 2.3.2, 2.2.2, and 2.1.1 === Installation & Usage README.rdoc @@ -20,10 +20,10 @@ Rake::TestTask.new(:test) do |t| t.verbose = true end -desc 'Test the GroupedScope plugin with Rails 2.1.1, 2.0.4 & 1.2.6 gems' +desc 'Test the GroupedScope plugin with Rails 2.3.2, 2.2.2, and 2.1.1 gems' task :test_rails do test = Rake::Task['test'] - versions = ['2.2.2','2.1.1','2.0.4','1.2.6'] + versions = ['2.3.2','2.2.2','2.1.1'] versions.each do |version| ENV['RAILS_VERSION'] = "#{version}" test.invoke Rakefile @@ -33,12 +33,6 @@ Gem::Specification.new do |s| "test/grouped_scope/self_grouping_test.rb", "test/helper.rb", "test/lib/boot.rb", - "test/lib/core_ext.rb", - "test/lib/named_scope.rb", - "test/lib/named_scope/core_ext.rb", - "test/lib/named_scope/named_scope.rb", - "test/lib/named_scope/named_scope_patch_1.2.rb", - "test/lib/named_scope/named_scope_patch_2.0.rb", "test/lib/test_case.rb" ] s.rdoc_options = ["--main", "README.rdoc"] s.extra_rdoc_files = ["README.rdoc","CHANGELOG","MIT-LICENSE"] grouped_scope.gemspec @@ -9,8 +9,6 @@ module GroupedScope def construct_sql_with_group_scope if @reflection.options[:grouped_scope] - # CHANGED [Rails 1.2.6] Account for quoted_table_name. - table_name = @reflection.respond_to?(:quoted_table_name) ? @reflection.quoted_table_name : @reflection.klass.table_name if @reflection.options[:as] # TODO: Need to add case for polymorphic :as option. else lib/grouped_scope/has_many_association.rb @@ -40,8 +40,6 @@ class GroupedScope::AssociationReflectionTest < GroupedScope::TestCase should 'delegate instance methods to #ungrouped_reflection' do methods = [:class_name,:klass,:table_name,:primary_key_name,:active_record, :association_foreign_key,:counter_cache_column,:source_reflection] - # CHANGED [Rails 1.2.6] Account for quoted_table_name. - methods << :quoted_table_name if @ungrouped_reflection.respond_to?(:quoted_table_name) methods.each do |m| assert_equal @ungrouped_reflection.send(m), @grouped_reflection.send(m), "The method #{m.inspect} does not appear to be proxied to the ungrouped reflection." @@ -54,17 +52,11 @@ class GroupedScope::AssociationReflectionTest < GroupedScope::TestCase end should 'derive class name to same as ungrouped reflection' do - # CHANGED [Rails 1.2.6] Account for quoted_table_name. - if @ungrouped_reflection.respond_to?(:derive_class_name) - assert_equal @ungrouped_reflection.send(:derive_class_name), @grouped_reflection.send(:derive_class_name) - end + assert_equal @ungrouped_reflection.send(:derive_class_name), @grouped_reflection.send(:derive_class_name) end should 'derive primary key name to same as ungrouped reflection' do - # CHANGED [Rails 1.2.6] Account for quoted_table_name. - if @ungrouped_reflection.respond_to?(:derive_primary_key_name) - assert_equal @ungrouped_reflection.send(:derive_primary_key_name), @grouped_reflection.send(:derive_primary_key_name) - end + assert_equal @ungrouped_reflection.send(:derive_primary_key_name), @grouped_reflection.send(:derive_primary_key_name) end should 'honor explicit legacy reports association options like class_name and foreign_key' do test/grouped_scope/association_reflection_test.rb @@ -28,5 +28,4 @@ require 'active_support' gem 'mislav-will_paginate', '2.3.4' require 'will_paginate' WillPaginate.enable_activerecord -require 'named_scope' test/lib/boot.rb test/lib/core_ext.rb test/lib/named_scope.rb test/lib/named_scope/core_ext.rb test/lib/named_scope/named_scope.rb test/lib/named_scope/named_scope_patch_1.2.rb test/lib/named_scope/named_scope_patch_2.0.rb 6fc2450f78909c7c149b51f1bcf4baedccfe73a1 Ken Collins ken@metaskills.net http://github.com/metaskills/grouped_scope/commit/85a743e805117fed447656d45de067865e13baa1 85a743e805117fed447656d45de067865e13baa1 2009-05-05T14:06:13-07:00 2009-05-05T14:06:13-07:00 Remove 1.2.6 and 2.0.1 support which used named scope hacks. b853c39bead8503c2ea87b016766f3a15c0436fe Ken Collins ken@metaskills.net