script/integration_test.rb @@ -1,4 +1,7 @@ require 'net/http' +require 'net/https' +require 'rubygems' +require 'active_support' # Plugin for applications to automatically post errors to the Hoptoad of their choice. module HoptoadNotifier @@ -58,6 +61,13 @@ module HoptoadNotifier end # Call this method to modify defaults in your initializers. + # + # HoptoadNotifier.configure do |config| + # config.api_key = '1234567890abcdef' + # config.secure = false + # end + # + # NOTE: secure connections are not yet supported. def configure yield self end @@ -105,8 +115,10 @@ module HoptoadNotifier end filter_backtrace do |line| - Gem.path.inject(line) do |line, path| - line.gsub(/#{path}/, "[GEM_ROOT]") + if defined?(Gem) + Gem.path.inject(line) do |line, path| + line.gsub(/#{path}/, "[GEM_ROOT]") + end end end @@ -217,7 +229,7 @@ module HoptoadNotifier } http.read_timeout = 5 # seconds http.open_timeout = 2 # seconds - # http.use_ssl = HoptoadNotifier.secure + http.use_ssl = !!HoptoadNotifier.secure response = begin http.post(url.path, stringify_keys(data).to_yaml, headers) rescue TimeoutError => e lib/hoptoad_notifier.rb @@ -5,8 +5,6 @@ require 'shoulda' require 'action_controller' require 'action_controller/test_process' require 'active_record' -require 'net/http' -require 'net/https' require File.join(File.dirname(__FILE__), "..", "lib", "hoptoad_notifier") RAILS_ROOT = File.join( File.dirname(__FILE__), "rails_root" ) @@ -355,6 +353,66 @@ class HoptoadNotifierTest < Test::Unit::TestCase @sender.stubs(:public_environment?).returns(true) end + context "when stubbing out Net::HTTP" do + setup do + @body = 'body' + @response = stub(:body => @body) + @http = stub(:post => @response, :read_timeout= => nil, :open_timeout= => nil, :use_ssl= => nil) + @sender.stubs(:logger).returns(stub(:error => nil, :info => nil)) + Net::HTTP.stubs(:start).yields(@http) + HoptoadNotifier.port = nil + HoptoadNotifier.host = nil + end + + context "on notify" do + setup { HoptoadNotifier.notify(@exception) } + + before_should "post to the right url for non-ssl" do + HoptoadNotifier.secure = false + url = "http://hoptoadapp.com:80/notices/" + uri = URI.parse(url) + URI.expects(:parse).with(url).returns(uri) + @http.expects(:post).with(uri.path, anything, anything).returns(@response) + end + + before_should "post to the right path" do + @http.expects(:post).with("/notices/", anything, anything).returns(@response) + end + + before_should "call send_to_hoptoad" do + @sender.expects(:send_to_hoptoad) + end + + before_should "set the open timeout to 2 seconds" do + @http.expects(:open_timeout=).with(2) + end + + before_should "set the read timeout to 5 seconds" do + @http.expects(:read_timeout=).with(5) + end + + before_should "connect to the right port for ssl" do + HoptoadNotifier.secure = true + Net::HTTP.expects(:start).with("hoptoadapp.com", 443).yields(@http) + end + + before_should "connect to the right port for non-ssl" do + HoptoadNotifier.secure = false + Net::HTTP.expects(:start).with("hoptoadapp.com", 80).yields(@http) + end + + before_should "use ssl if secure" do + HoptoadNotifier.secure = true + @http.expects(:use_ssl=).with(true) + end + + before_should "not use ssl if not secure" do + HoptoadNotifier.secure = nil + @http.expects(:use_ssl=).with(false) + end + end + end + should "send as if it were a normally caught exception" do @sender.expects(:notify_hoptoad).with(@exception) HoptoadNotifier.notify(@exception) test/hoptoad_notifier_test.rb 9b00fbd4fb4cadc0dd6bde631a2dd4f00eab24ff bdd26b36fab9f52951c6f6a2626b93d90dfa68b1 Jon Yurek jyurek@thoughtbot.com http://github.com/methodmissing/hoptoad_notifier/commit/38056601e3cc15a086df0e19d2ffcb585127a0fe 38056601e3cc15a086df0e19d2ffcb585127a0fe 2008-11-19T08:56:15-08:00 2008-11-19T08:56:15-08:00 Merge branch 'master' of git@github.com:thoughtbot/hoptoad_notifier 922f8a9269964fa86cbf4b7e83cfe5476eb8102e Jon Yurek jyurek@thoughtbot.com