New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Midgard Collector produces invalid SQL #22

Closed

bergie opened this issue Jun 1, 2010 · 1 comment

Labels

Member

bergie commented Jun 1, 2010

If an empty array is given to collector (in following example) you'll end up having malformed SQL.

$mc = new midgard_collector('someobject', 'active',  true);
$mc->add_constraint('id', 'IN', $empty_array_or_null);
$mc->set_key_property('guid');
$mc->execute();

This should return empty resultset or throw an exception that empty array has been given for IN constraint.
http://static.qaiku.com/dd8/6f6/ca4/dd86f6ca46bc11df83b0b7855095acc8acc8.gif

(copied from http://trac.midgard-project.org/ticket/1754)

The text was updated successfully, but these errors were encountered:

Member

piotras commented Nov 26, 2010

Return fail if condition build failed. Closed by ce4b9ba

piotras added a commit that referenced this issue


          Return fail if condition build failed. Fixes #22

ce4b9ba

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment