Issues - mikel/tmail

mikel / tmail

Description:

TMail is a Ruby Email Handler.

Sort by: Priority | Votes | Last Updated

Loading…

2.

0 votes

use TMail::Mail#charset when unquoting the body
3 comments Created 5 months ago by technoweenie

Title

Body
Here's a small patch for TMail: http://gist.github.com/raw/141602/3ef8b5e6c518da9fe90c032cbe58d8f1a07a6ddb/gistfile1.txt I don't know if there's any reason to use #sub_header there, but I needed this for an ugly monkey patch I had to write. I have to process some spam emails with the charset specified in the mime-version header. I know, it's completely uncalled for, but what can I do? Here's what I'm using now: http://gist.github.com/141603 If you think this hack is a good idea for TMail, I'll gladly work it into a patch too.
or cancel

Here's a small patch for TMail: http://gist.github.com/raw/141602/3ef8b5e6c518da9fe90c032cbe58d8f1a07a6ddb/gistfile1.txt

I don't know if there's any reason to use #sub_header there, but I needed this for an ugly monkey patch I had to write. I have to process some spam emails with the charset specified in the mime-version header. I know, it's completely uncalled for, but what can I do? Here's what I'm using now:

http://gist.github.com/141603

If you think this hack is a good idea for TMail, I'll gladly work it into a patch too.

Comments

mikel Tue Jul 07 22:58:17 -0700 2009 | link

Heya, thanks for the patch.

Lets work the overall idea into a patch with a test case showing an email that does this. You can whack a test onto the end of test_header.rb with the specific example of an email, as long as it helps tmail read that email and doesn't break any other tests, should be good to go.

Mikel

Comment
Heya, thanks for the patch. Lets work the overall idea into a patch with a test case showing an email that does this. You can whack a test onto the end of test_header.rb with the specific example of an email, as long as it helps tmail read that email and doesn't break any other tests, should be good to go. Mikel
or cancel

technoweenie Wed Jul 08 20:06:12 -0700 2009 | link

No problem... I have a test case but it's wrapped up in astrotrain. I'll extract it and submit a proper tmail patch soon.

Comment
No problem... I have a test case but it's wrapped up in astrotrain. I'll extract it and submit a proper tmail patch soon.
or cancel

mikel Mon Aug 03 21:05:23 -0700 2009 | link

Did you get any where with this patch Rick?

Looking at doing another gem release soon and would like to include your work.

Mikel

Comment
Did you get any where with this patch Rick? Looking at doing another gem release soon and would like to include your work. Mikel
or cancel

Parsed with GitHub Flavored Markdown
1.

0 votes

Fix parser to raise a TMail::SyntaxError, not a SyntaxError
1 comment Created 7 months ago by technoweenie

Title

Body
I had a problem where a SyntaxError from TMail::Address.parse that kept halting my Delayed::Job queue. I suspect this is because SyntaxError is a core ruby exception. The patch ensures that the parser raises TMail::SyntaxError. Here's the patch, suitable for use with `git am` http://gist.github.com/raw/116691/6631781ad06d5f2d10bcd3c41ed0c5910be2d7cd/gistfile1.txt Here's a small example that shows the error: >> TMail::Address.parse "( |" SyntaxError: unterminated comment from parser.y:375:in `scan' from parser.y:375:in `parse_in' from racc/parser.rb:152:in `_racc_yyparse_c' from racc/parser.rb:152:in `__send__' from racc/parser.rb:152:in `yyparse' from parser.y:366:in `parse' from parser.y:344:in `parse' from /Library/Ruby/Gems/1.8/gems/tmail-1.2.3.1/lib/tmail/address.rb:84:in `parse' from (irb):1
or cancel
I had a problem where a SyntaxError from TMail::Address.parse that kept halting my Delayed::Job queue. I suspect this is because SyntaxError is a core ruby exception. The patch ensures that the parser raises TMail::SyntaxError.

Here's the patch, suitable for use with git am
http://gist.github.com/raw/116691/6631781ad06d5f2d10bcd3c41ed0c5910be2d7cd/gistfile1.txt

Here's a small example that shows the error:
```
>> TMail::Address.parse "( |"
SyntaxError: unterminated comment
  from parser.y:375:in `scan'
  from parser.y:375:in `parse_in'
  from racc/parser.rb:152:in `_racc_yyparse_c'
  from racc/parser.rb:152:in `__send__'
  from racc/parser.rb:152:in `yyparse'
  from parser.y:366:in `parse'
  from parser.y:344:in `parse'
  from /Library/Ruby/Gems/1.8/gems/tmail-1.2.3.1/lib/tmail/address.rb:84:in `parse'
  from (irb):1
```
Comments

mikel Thu Jul 02 22:59:57 -0700 2009 | link

Thanks! Applied.

Comment
Thanks! Applied.
or cancel

Parsed with GitHub Flavored Markdown

Labels

use TMail::Mail#charset when unquoting the body

Comments

Fix parser to raise a TMail::SyntaxError, not a SyntaxError

Comments