@@ -3,7 +3,7 @@ converts them to Ruby objects when appropiate. Also, it converts the request method from the Facebook POST to the original HTTP method used by the client. -If the signature is wrong, it returns a "404 Invalid Facebook Signature". +If the signature is wrong, it returns a "400 Invalid Facebook Signature". Optionally, it can take a block that receives the Rack environment and returns a value that evaluates to true when we want the middleware to README.markdown @@ -4,7 +4,7 @@ module Rack # the request method from the Facebook POST to the original HTTP # method used by the client. # - # If the signature is wrong, it returns a "404 Invalid Facebook Signature". + # If the signature is wrong, it returns a "400 Invalid Facebook Signature". # # Optionally, it can take a block that receives the Rack environment # and returns a value that evaluates to true when we want the middleware to @@ -35,7 +35,7 @@ module Rack req = Rack::Request.new(env) fb_params = extract_fb_sig_params(req.POST) unless signature_is_valid?(fb_params, req.POST['fb_sig']) - return [404, {"Content-Type" => "text/html"}, ["Invalid Facebook signature"]] + return [400, {"Content-Type" => "text/html"}, ["Invalid Facebook signature"]] end env['REQUEST_METHOD'] = fb_params["request_method"] convert_parameters!(req.POST) lib/rack/facebook.rb @@ -4,7 +4,7 @@ require 'rack/facebook' describe Rack::Facebook do describe 'without a block' do describe 'when the fb_sig is not valid' do - it 'should return 404 Invalid Facebook signature' + it 'should return 400 Invalid Facebook signature' end describe 'when the fb_sig is valid' do spec/rack-facebook_spec.rb 56edc6c702a45b4e7f679d4fc9e82613089ac6d9 Carlos Paramio carlosparamio@gmail.com http://github.com/mislav/rack-facebook/commit/b19cd41e42f8bd8f30b0ee29be8c1b9f97202482 b19cd41e42f8bd8f30b0ee29be8c1b9f97202482 2009-01-09T05:00:41-08:00 2009-01-09T05:00:41-08:00 change http status code for bad requests to 400 a781e6fb89550e69e1eaa85dc5667110c1567491 Carlos Paramio carlosparamio@gmail.com