mislav / will_paginate
watch download tarball
public
Forks163Right
Watchers2021Right
Description: Adaptive pagination plugin for web frameworks and other applications
Homepage: http://github.com/mislav/will_paginate/wikis
Clone URL: git://github.com/mislav/will_paginate.git
Click here to lend your support to: will_paginate and make a donation at www.pledgie.com !

Comments for mislav's will_paginate   feed

mislav commented on mislav/will_paginate Mon Dec 01 10:19:41 -0800 2008
Comment in 5adc2de:

Can you be more specific?

viniciusluiz commented on mislav/will_paginate Mon Dec 01 06:33:59 -0800 2008
Comment in 5adc2de:

The distinct does not work

@cities = City.paginate(:all, :select=>’DISTINCT name, state_id’, :page => params[:page], :order => ‘state_id ASC, name ASC’, :per_page => 10)

att,

kneath commented on mislav/will_paginate Sun Oct 12 21:48:00 -0700 2008
Comment in 8c585a7:

@spovich: You can actually still style tags the same as class names. A old style for .pagination .current{} will be equal to a new style for .pagination em{}

spovich commented on mislav/will_paginate Sun Oct 12 21:08:14 -0700 2008
Comment in 8c585a7:

I also question this change. How are you supposed to style the output when you have removed the class declaration? I though was basically just a tag. Can you do ?

kneath commented on mislav/will_paginate Sun Oct 12 13:53:20 -0700 2008
Comment in 8c585a7:

While I do agree with this semantically, I strongly oppose this in practice. This is going to break everyone’s current styles. And in a way that won’t be breaking tests/specs — it’ll just be breaking the visual representation (something that users will probably find first).

This may have been a poor semantic decision when wp was first created, but I think changing it now would be a far worse decision.

mislav commented on mislav/will_paginate Sat Oct 11 12:26:09 -0700 2008
Comment in 0318fff:

Hey Ken,

If you look at line http://github.com/mislav/will_paginate/tree/0318fffa658911ee795e9c741f18616b3b651eb6/lib/will_paginate.rb#L60, you’ll see that you required ‘will_paginate/named_scope_patch’. This line was the same after your initial patch. Your version-specific changes never really got require’d. I then fixed the code to actually require version-specific files, which horribly broke tests for Rails versions 2.0.4 and 1.2.6, leading me to realize that you probably forgot to test them. I removed them and reverted to the file that was used all along and that works (all tests pass).

metaskills commented on mislav/will_paginate Fri Oct 10 15:14:59 -0700 2008
Comment in 0318fff:

Why the revert? FYI, I was working on another patch to submit this plugin into WillPaginate <http://github.com/metaskills/named_scope/tree/master> which is well tested since it uses the rails 2.1.1 tests (converted to shoulda/factory_girl ofcourse).

mislav commented on mislav/will_paginate Tue Sep 30 13:59:25 -0700 2008
Comment in dd5cba2:

Woah. I’m stoopid. Thanks

metaskills commented on mislav/will_paginate Tue Sep 30 11:25:27 -0700 2008
Comment in dd5cba2:

The version.rb needs to be updated too.

chriseppstein commented on mislav/will_paginate Tue Apr 29 14:30:51 -0700 2008
Comment in 2e45f01:

very nice. Thank you for taking my change to the next level.

mislav commented on mislav/will_paginate Mon Apr 21 08:28:21 -0700 2008
Comment on test/view_test.rb L160 in cc1516d:

Kids, always add tests for discovered bugs!

mislav commented on mislav/will_paginate Mon Apr 21 08:27:45 -0700 2008
Comment on lib/will_paginate/view_helpers.rb L143 in cc1516d:

If someone has a suggestion for a better message, shoot!