Issues - mixonic/tables_on_cows

mixonic / tables_on_cows

Description:

MooTools based table sort and pagination. Quick and slim.

Sort by: Priority | Votes | Last Updated

Loading…

1.

0 votes

Conversions
1 comment Created 4 months ago by NathanSudell

Title

Body
An easier way to add conversions would be nice. A few suggestions: 1. return "this" from initialize, so this.conversions can be extended 2. create an "addConversions" method (would require 1.) 3. accept an array of conversions in the options and automatically addConversions .... and of course added conversions would have to precede the defaults or they'll never be checked.
or cancel
An easier way to add conversions would be nice. A few suggestions:
1. return "this" from initialize, so this.conversions can be extended
2. create an "addConversions" method (would require 1.)
3. accept an array of conversions in the options and automatically addConversions
.... and of course added conversions would have to precede the defaults or they'll never be checked.
Comments

mixonic Fri Oct 16 11:41:15 -0700 2009 | link

Hi Nathan,

I would expect the first option already works. Option three sounds good for extending a given instance, I'll look into it.

Leaving this open until something is added to make adding conversions simpler (or at least documented).

Comment
Hi Nathan, I would expect the first option already works. Option three sounds good for extending a given instance, I'll look into it. Leaving this open until something is added to make adding conversions simpler (or at least documented).
or cancel

Parsed with GitHub Flavored Markdown
2.

0 votes

Empty Cells
0 comments Created 4 months ago by NathanSudell

Title

Body
If all the cells of a column are empty then no conversion function is retrieved, but this.conversion(rows) is still called, resulting in a "function expected" error. needs a simple "if this.conversion != false".
or cancel

If all the cells of a column are empty then no conversion function is retrieved, but this.conversion(rows) is still called, resulting in a "function expected" error. needs a simple "if this.conversion != false".

Comments

Parsed with GitHub Flavored Markdown
3.

0 votes

sorting text with lower case, accents, etc
3 comments Created about 1 month ago by jlin

Title

Body
Hello! I was trying out this code, and I have some text in lowercase, and also with some French accents. The lower case characters were sorted after all the uppercase, and the text with accents appeared even farther below that. Is this a problem with my set up, or is the default text sorter just doing an ascii sort? or would there be a way to correct this, maybe via a custom sorter?
or cancel

Hello!

I was trying out this code, and I have some text in lowercase, and also with some French accents. The lower case characters were sorted after all the uppercase, and the text with accents appeared even farther below that.

Is this a problem with my set up, or is the default text sorter just doing an ascii sort? or would there be a way to correct this, maybe via a custom sorter?

Comments

jlin Fri Oct 09 23:20:10 -0700 2009 | link

I got around this by add in .toLowerCase(); and then running a regex replacement to strip out possible diacritics on vowels and letters in the fallback text conversion function. It's not very elegent, but I don't know much javascript, and it seems to do the trick.

Comment
I got around this by add in .toLowerCase(); and then running a regex replacement to strip out possible diacritics on vowels and letters in the fallback text conversion function. It's not very elegent, but I don't know much javascript, and it seems to do the trick.
or cancel

jlin Fri Oct 09 23:20:39 -0700 2009 | link

I guess this is now closed?

Comment
I guess this is now closed?
or cancel

mixonic Fri Oct 16 11:38:33 -0700 2009 | link

Hey jlin! Do you have a patch anywhere? I agree actually running a comparison on the accented characters would be ideal, and I would have expected it to be built into the normal Javascript comparison.

Let me know if you have a patch, but otherwise I'm going to leave this open until I build a fix.

Thanks.

Comment
Hey jlin! Do you have a patch anywhere? I agree actually running a comparison on the accented characters would be ideal, and I would have expected it to be built into the normal Javascript comparison. Let me know if you have a patch, but otherwise I'm going to leave this open until I build a fix. Thanks.
or cancel

Parsed with GitHub Flavored Markdown
5.

0 votes

Decimal numbers
1 comment Created about 1 month ago by hitsvilleusa

Title

Body
Perhaps I am missing something, but I don't feel like this is appropriately sorting floating point numbers (including currency). I feel like this library has a lot of promise, but it falls down by converting everything to a string and sorting those.
or cancel

Perhaps I am missing something, but I don't feel like this is appropriately sorting floating point numbers (including currency). I feel like this library has a lot of promise, but it falls down by converting everything to a string and sorting those.

Comments

mixonic Fri Oct 16 11:52:24 -0700 2009 | link

Hi hitsvilleusa,

Converting to a string is actually the strength of this library. If you read the blog articles discussing the technique, you'll know it's the fastest way to sort content in Javascript. If you know of a better technique hook us up! :-)

There is a matcher for currency (floats with a precision of 2). I'm not certain what would happen sorting raw floats, but I don't think the behavior would be something expected.

I'll leave this open until we get a conversion for arbitrary length floats. Patches are always welcome! Let me know if the documentation is unclear about how to add a conversion.

Thanks.

Comment
Hi hitsvilleusa, Converting to a string is actually the strength of this library. If you read the blog articles discussing the technique, you'll know it's the fastest way to sort content in Javascript. If you know of a better technique hook us up! :-) There is a matcher for currency (floats with a precision of 2). I'm not certain what would happen sorting raw floats, but I don't think the behavior would be something expected. I'll leave this open until we get a conversion for arbitrary length floats. Patches are always welcome! Let me know if the documentation is unclear about how to add a conversion. Thanks.
or cancel

Parsed with GitHub Flavored Markdown

Labels

Conversions

Comments

Empty Cells

Comments

sorting text with lower case, accents, etc

Comments

Decimal numbers

Comments