@@ -4,3 +4,4 @@ ext/decoder.bundle ext/decoder.o *.beam *.dump +.DS_Store .gitignore @@ -1,4 +1,8 @@ -== +== 1.0.1 / 2009-05-03 + * Bug Fixes + * Fix premature null byte termination on binary decode + +== 1.0.0 / 2009-04-29 * Backward Incompatible Changes * Implicit array call for f.when(:echo, String) must now be called as f.when([:echo, String]) to eliminate ambiguity History.txt @@ -146,7 +146,7 @@ VALUE read_bin(unsigned char **pData) { unsigned char buf[length + 1]; read_string_raw(buf, pData, length); - return rb_str_new2((char *) buf); + return rb_str_new((char *) buf, length); } VALUE read_string(unsigned char **pData) { ext/decoder.c @@ -107,6 +107,7 @@ context "When unpacking from a binary stream" do specify "an erlang binary should decode to a string" do get("<< 3,4,255 >>").should == "\003\004\377" get("<< \"whatup\" >>").should == "whatup" + get("<< 99,0,99 >>").should == "c\000c" end specify "erlang atomic booleans should decode to ruby booleans" do test/decode_spec.rb @@ -112,6 +112,7 @@ context "When packing to a binary stream" do specify "a string should be encoded as a erlang binary would be" do get{@encoder.write_binary "hey who"}.should == get_erl("<< \"hey who\" >>") get{@encoder.write_binary ""}.should == get_erl("<< \"\" >>") + get{@encoder.write_binary "c\000c"}.should == get_erl("<< 99,0,99 >>") write_any("hey who").should == get_erl_with_magic("<< \"hey who\" >>") write_any("").should == get_erl_with_magic("<< \"\" >>") test/encode_spec.rb ca9a482d5a203dbbae80c991c24e00c1eaa1e3b1 Tom Preston-Werner tom@mojombo.com http://github.com/mojombo/erlectricity/commit/81a6709fcac35eb59619ad31231ec3e4eef05790 81a6709fcac35eb59619ad31231ec3e4eef05790 2009-05-03T23:02:07-07:00 2009-05-03T23:00:54-07:00 fix null byte causing premature termination of strings on decode 27b80611be93c05fafd132e4619f69c8da6014d1 Tom Preston-Werner tom@mojombo.com