@@ -1,3 +1,7 @@ +== + * Bug Fixes + * Fix bignum encoding + == 1.1.0 / 2009-10-08 * Minor Improvements * Implement Bignum encoding History.txt @@ -101,10 +101,10 @@ module Erlectricity def write_bignum_guts(num) write_1 (num >= 0 ? 0 : 1) num = num.abs - i = 0 - while (rem = (num >> i * 8) % (256)) != 0 + while num != 0 + rem = num % 256 write_1 rem - i += 1 + num = num >> 8 end end lib/erlectricity/encoder.rb @@ -36,6 +36,7 @@ context "When packing to a binary stream" do write_any(-(1 << 27)).should == get_erl_with_magic("#{-(1 << 27)}") # #SMALL_BIGNUMS + get{@encoder.write_fixnum(10_000_000_000_000_000_000)}.should == get_erl("10000000000000000000") get{@encoder.write_fixnum(1254976067)}.should == get_erl("1254976067") get{@encoder.write_fixnum(-1254976067)}.should == get_erl("-1254976067") # get{@encoder.write_fixnum((1 << word_length))}.should == get_erl("#{(1 << word_length)}") test/encode_spec.rb 2c5c4c472aebefdebdfacc225e9e4dfb9c10fb5f Tom Preston-Werner tom@mojombo.com http://github.com/mojombo/erlectricity/commit/9257ecc222ba5e489ced8d40c6190a4d1aea2826 9257ecc222ba5e489ced8d40c6190a4d1aea2826 2009-10-28T12:19:56-07:00 2009-10-28T12:19:56-07:00 fix bignum encoding 05c9188cc2cde6d957375f3305eab2e0c135d737 Tom Preston-Werner tom@mojombo.com